search

kubevirt / containerized-data-importer

Data Import Service for kubernetes, designed with kubevirt in mind.
Apache License 2.0
413 stars 259 forks source link

Fix flaking cert rotation unit test #3340

Closed akalenyu closed 2 months ago

akalenyu commented 3 months ago

What this PR does / why we need it: The theory is that the worker that runs unit tests is not always UTC based, so this fails when it's not. https://github.com/kubevirt/containerized-data-importer/blob/e75b580646ec2813002fe93eca4152c041b41941/pkg/operator/controller/certrotation.go#L188

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Release note:

NONE
kubevirt-bot commented 3 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

kubevirt-bot commented 3 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from akalenyu. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubevirt/containerized-data-importer/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
akalenyu commented 3 months ago

/test pull-cdi-goveralls /test pull-cdi-unit-test

coveralls commented 3 months ago

Coverage Status

coverage: 58.978% (-0.007%) from 58.985% when pulling 586dd848324d78622aa658f7d057d14637b8ab4e on akalenyu:fix-certrotation-tests-utc into da3d7a146e5b6883da5f6c5593e5ee929639772c on kubevirt:main.

akalenyu commented 3 months ago

/test pull-cdi-goveralls /test pull-cdi-unit-test

akalenyu commented 3 months ago

/test pull-cdi-goveralls /test pull-cdi-unit-test

akalenyu commented 3 months ago

/test pull-cdi-goveralls /test pull-cdi-unit-test

akalenyu commented 3 months ago

/test pull-cdi-goveralls /test pull-cdi-unit-test

akalenyu commented 3 months ago

/test pull-cdi-goveralls /test pull-cdi-unit-test

akalenyu commented 3 months ago

/test pull-cdi-goveralls /test pull-cdi-unit-test

akalenyu commented 3 months ago

/test pull-cdi-goveralls /test pull-cdi-unit-test

akalenyu commented 3 months ago

/test pull-cdi-goveralls /test pull-cdi-unit-test

akalenyu commented 3 months ago

/test pull-cdi-goveralls /test pull-cdi-unit-test

akalenyu commented 3 months ago

/test pull-cdi-goveralls /test pull-cdi-unit-test

akalenyu commented 3 months ago

/test pull-cdi-goveralls /test pull-cdi-unit-test

akalenyu commented 3 months ago

/test pull-cdi-goveralls /test pull-cdi-unit-test

akalenyu commented 3 months ago

/test pull-cdi-goveralls /test pull-cdi-unit-test

akalenyu commented 3 months ago

/test pull-cdi-goveralls /test pull-cdi-unit-test

akalenyu commented 2 months ago

/test pull-cdi-goveralls /test pull-cdi-unit-test

akalenyu commented 2 months ago

/test pull-cdi-goveralls /test pull-cdi-unit-test

akalenyu commented 2 months ago

/test pull-cdi-goveralls /test pull-cdi-unit-test

akalenyu commented 2 months ago

/test pull-cdi-goveralls /test pull-cdi-unit-test

akalenyu commented 2 months ago

/test pull-cdi-goveralls /test pull-cdi-unit-test

akalenyu commented 2 months ago

/test pull-cdi-goveralls /test pull-cdi-unit-test

akalenyu commented 2 months ago

/test pull-cdi-goveralls /test pull-cdi-unit-test

akalenyu commented 2 months ago

/close https://github.com/kubevirt/containerized-data-importer/pull/3342

kubevirt-bot commented 2 months ago

@akalenyu: Closed this PR.

In response to [this](https://github.com/kubevirt/containerized-data-importer/pull/3340#issuecomment-2221061497): >/close >https://github.com/kubevirt/containerized-data-importer/pull/3342 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.