search

kubevirt / containerized-data-importer

Data Import Service for kubernetes, designed with kubevirt in mind.
Apache License 2.0
413 stars 259 forks source link

Inject cdi-uploadproxy CA cert into user created routes #3380

Closed mhenriks closed 1 month ago

mhenriks commented 1 month ago

What this PR does / why we need it:

Users want to create their own routes but certificate rotation make it difficult to keep them up to date

To take advantage of this feature, routes must meet the following restrictions:

  1. Be in the same namespace as cdi-operator
  2. have operator.cdi.kubevirt.io/injectUploadProxyCert: "true" annotation

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

https://issues.redhat.com/browse/CNV-31492

Special notes for your reviewer:

Release note:

Inject cdi-uploadproxy CA cert into user created routes
coveralls commented 1 month ago

Coverage Status

coverage: 59.151% (-0.006%) from 59.157% when pulling 36f1d191924abd0d2297269b6fd7ea89bfbb3048 on mhenriks:export-server-route-mgmt into 988dc68d158be513b76f2144c602424692987dd9 on kubevirt:main.

kubevirt-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akalenyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/containerized-data-importer/blob/main/OWNERS)~~ [akalenyu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
awels commented 1 month ago

/lgtm

mhenriks commented 1 month ago

/cherrypick release-v1.59

kubevirt-bot commented 1 month ago

@mhenriks: #3380 failed to apply on top of branch "release-v1.59":

Applying: Inject cdi-uploadproxy CA cert into user created routes
Using index info to reconstruct a base tree...
M   pkg/operator/controller/callbacks.go
M   pkg/operator/controller/controller.go
M   pkg/operator/controller/controller_test.go
M   pkg/operator/controller/route.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/operator/controller/route.go
CONFLICT (content): Merge conflict in pkg/operator/controller/route.go
Auto-merging pkg/operator/controller/controller_test.go
Auto-merging pkg/operator/controller/controller.go
Auto-merging pkg/operator/controller/callbacks.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Inject cdi-uploadproxy CA cert into user created routes
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/kubevirt/containerized-data-importer/pull/3380#issuecomment-2310276945): >/cherrypick release-v1.59 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.