kubevirt / containerized-data-importer

Data Import Service for kubernetes, designed with kubevirt in mind.
Apache License 2.0
413 stars 259 forks source link

fix(import-populator): Make copying of annotations more robust #3388

Closed 0xFelix closed 1 month ago

0xFelix commented 1 month ago

What this PR does / why we need it:

Similar to 2fa5f27, make copying of annotations from a prime PVC to a target PVC more robust, by moving it before rebinding the PV from prime to target. This way we can ensure the annotations are already present once the PVC becomes ready.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Release note:

None
0xFelix commented 1 month ago

@akalenyu PTAL, not sure this is 100% required.

coveralls commented 1 month ago

Coverage Status

coverage: 59.162% (-0.01%) from 59.176% when pulling 306054857a7b2dc40d3d99644169de34e1ab990d on 0xFelix:import-annotations into 5d7fe964a548da1e215b1dbc7b6e549deccd553f on kubevirt:main.

0xFelix commented 1 month ago

@akalenyu Do you think this is still needed?

akalenyu commented 1 month ago

@akalenyu Do you think this is still needed?

I think so, yeah It's completely possible that the annotations only make it after the target is rebound If you want you can close this and just open an issue to track and we will take it from there

0xFelix commented 1 month ago

@akalenyu It looks better now, wdyt?

akalenyu commented 1 month ago

/cc @alromeros @mhenriks wdyt?

mhenriks commented 1 month ago

looks good I think but I'll let @alromeros be the judge

alromeros commented 1 month ago

Thanks! /lgtm

mhenriks commented 1 month ago

/approve

kubevirt-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mhenriks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/containerized-data-importer/blob/main/OWNERS)~~ [mhenriks] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
0xFelix commented 1 month ago

/retest-required

awels commented 1 month ago

/test pull-containerized-data-importer-fossa