Closed 0xFelix closed 1 month ago
@akalenyu PTAL, not sure this is 100% required.
@akalenyu Do you think this is still needed?
@akalenyu Do you think this is still needed?
I think so, yeah It's completely possible that the annotations only make it after the target is rebound If you want you can close this and just open an issue to track and we will take it from there
@akalenyu It looks better now, wdyt?
/cc @alromeros @mhenriks wdyt?
looks good I think but I'll let @alromeros be the judge
Thanks! /lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: mhenriks
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/retest-required
/test pull-containerized-data-importer-fossa
What this PR does / why we need it:
Similar to 2fa5f27, make copying of annotations from a prime PVC to a target PVC more robust, by moving it before rebinding the PV from prime to target. This way we can ensure the annotations are already present once the PVC becomes ready.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged): Fixes #Special notes for your reviewer:
Release note: