search

kubevirt / containerized-data-importer

Data Import Service for kubernetes, designed with kubevirt in mind.
Apache License 2.0
413 stars 259 forks source link

Run make rpm-deps to udpate dependencies for all arches #3405

Closed awels closed 1 month ago

awels commented 1 month ago

What this PR does / why we need it: Ensure the dependencies are up to date so we can easily merge with s390x PRs in the future.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Release note:

NONE
mhenriks commented 1 month ago

/lgtm

akalenyu commented 1 month ago

So this is going to have issues with the latest nginx version and https imports:

$ k logs -n cdi cdi-file-host-8449b596c9-4pq6g | grep dumped
selecting docker as container runtime
Defaulted container "http" out of: http, s3, init (init)
2024/08/21 16:28:14 [alert] 1#1: worker process 2 exited on signal 11 (core dumped)
2024/08/21 16:28:14 [alert] 1#1: worker process 3 exited on signal 11 (core dumped)
2024/08/21 16:28:15 [alert] 1#1: worker process 4 exited on signal 11 (core dumped)
2024/08/21 16:28:15 [alert] 1#1: worker process 5 exited on signal 11 (core dumped)
2024/08/21 16:28:28 [alert] 1#1: worker process 6 exited on signal 11 (core dumped)
2024/08/21 16:28:28 [alert] 1#1: worker process 7 exited on signal 11 (core dumped)
2024/08/21 16:28:59 [alert] 1#1: worker process 8 exited on signal 11 (core dumped)
2024/08/21 16:28:59 [alert] 1#1: worker process 9 exited on signal 11 (core dumped)

Good news is that I have a commit freezing nginx to a "good" version, if you can give me rights to your fork I'll push it.

akalenyu commented 1 month ago

/test pull-cdi-unit-test

awels commented 1 month ago

/test pull-cdi-unit-test

awels commented 1 month ago

/lgtm

kubevirt-bot commented 1 month ago

@awels: you cannot LGTM your own PR.

In response to [this](https://github.com/kubevirt/containerized-data-importer/pull/3405#issuecomment-2302938655): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
akalenyu commented 1 month ago

/approve /lgtm

kubevirt-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akalenyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/containerized-data-importer/blob/main/OWNERS)~~ [akalenyu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
akalenyu commented 1 month ago

/test pull-containerized-data-importer-e2e-istio