search

kubevirt / containerized-data-importer

Data Import Service for kubernetes, designed with kubevirt in mind.
Apache License 2.0
428 stars 269 forks source link

[WIP] Change clone strategy to avoid PowerStore snapshot limits #3520

Open coulof opened 2 weeks ago

coulof commented 2 weeks ago

What this PR does / why we need it: PowerStore has a limit of 32 to 64 writable snapshots which prevents to create more VMs from a base OS.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Release note:

* Dell PowerStore uses `cloneStrategy: copy` over `csi-clone` to avoid array snapshot limits
kubevirt-bot commented 2 weeks ago

Hi @coulof. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
kubevirt-bot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign akalenyu for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubevirt/containerized-data-importer/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
akalenyu commented 2 weeks ago

So CSI/snapshot clones normally create ephemeral snapshots, which should keep us within limits. Could you please attach some PowerStore source? I am probably misunderstanding the issue.

I want to ensure I poke at this a bit, since doing host assisted clones all over is going to be a major hit for anyone who uses this solution.