search

kubevirt / containerized-data-importer

Data Import Service for kubernetes, designed with kubevirt in mind.
Apache License 2.0
428 stars 269 forks source link

Fix the location of the nightly commit file #3521

Closed nunnatsa closed 2 weeks ago

nunnatsa commented 2 weeks ago

What this PR does / why we need it:

The nightly build commit file should be under the specific build directory, but was placed under the parent directory by mistake.

This PR fixes the commit file location.

The right location is:

https://storage.googleapis.com/kubevirt-prow/devel/nightly/release/kubevirt/containerized-data-importer/{latest}/commit

(while "latest" is https://storage.googleapis.com/kubevirt-prow/devel/nightly/release/kubevirt/containerized-data-importer/latest)

The wrong location is here:

https://storage.googleapis.com/kubevirt-prow/devel/nightly/release/kubevirt/containerized-data-importer/commit

Release note:

None
coveralls commented 2 weeks ago

Coverage Status

coverage: 59.288% (+0.02%) from 59.27% when pulling bb8c81748657a5290dd1c94c0d7e5f7739398313 on nunnatsa:fix-nightly-commit-location into 13c2bf51953c55c6fcef6ac803630c7b3ec83ed8 on kubevirt:main.

awels commented 2 weeks ago

/retest-required

awels commented 2 weeks ago

/lgtm /approve

kubevirt-bot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awels

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/containerized-data-importer/blob/main/OWNERS)~~ [awels] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment