search

kubevirt / csi-driver

KubeVirt CSI driver
Other
39 stars 27 forks source link

Allow RWX, FS infra PVC #107

Closed nunnatsa closed 5 months ago

nunnatsa commented 5 months ago

What this PR does / why we need it: For RWX pvc request, don't limit the infra PVC to be Block, but also allow FS.

Release note:

For RWX pvc request, don't limit the infra PVC to be Block, but also allow FS.
nunnatsa commented 5 months ago

/retest

kubevirt-bot commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awels

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/csi-driver/blob/main/OWNERS)~~ [awels] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
awels commented 5 months ago

Looks like maybe you need a rebase? We made some changes to the RBAC in particular for volume snapshots.