search

kubevirt / csi-driver

KubeVirt CSI driver
Other
34 stars 25 forks source link

Use default infra storage class when no infra storage class is defined #73

Closed davidvossel closed 1 year ago

davidvossel commented 1 year ago

If there's no infra storage class defined in the guest storage class, use the default one. This gives us a default option where we can create a standard StorageClass object in the guest that will work across all infra as long as the infra defines a default itself.

This behavior is enforced on the infra side by the work @isaacdorfman perfomed in https://github.com/kubevirt/csi-driver/pull/62

NONE
davidvossel commented 1 year ago

/retest

awels commented 1 year ago

/lgtm

davidvossel commented 1 year ago

/approve

kubevirt-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidvossel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/csi-driver/blob/main/OWNERS)~~ [davidvossel] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment