search

kubevirt / csi-driver

KubeVirt CSI driver
Other
34 stars 25 forks source link

Ensure volume is hotplugged before returning ControllerPublishVolume #82

Closed awels closed 1 year ago

awels commented 1 year ago

Signed-off-by: Alexander Wels awels@redhat.com

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer: Sometimes pods would generate events noting the volume could not be mounted due to not finding it by serial. This was because the code was not waiting for the volume to be fully hotplugged into the node before returning. This caused an attempt to stage the volume on the node before the volume was fully attached.

Modified some error messages to not start with Upper case per golang error message guidelines.

Release note:

NONE
kubevirt-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidvossel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/csi-driver/blob/main/OWNERS)~~ [davidvossel] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment