search

kubevirt / csi-driver

KubeVirt CSI driver
Other
34 stars 25 forks source link

Make Controller Unpublish idempotent. #88

Closed awels closed 1 year ago

awels commented 1 year ago

What this PR does / why we need it: There was a race condition in unpublish that would sometimes get into an error state that it would never get out of causing unpublish to never happen even though the datavolume was unplugged from the VM already.

Update the k8s version used during testing to be more in line with the CSI version. Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Release note:

BugFix: Fixed issue with Controller Unpublish not being idem potent.
kubevirt-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidvossel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/csi-driver/blob/main/OWNERS)~~ [davidvossel] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment