search

kubevirt / demo

Easy to use KubeVirt demo based on minikube.
Apache License 2.0
108 stars 59 forks source link

Updated to kubevirt v0.24.0 #125

Closed omeryahud closed 4 years ago

kubevirt-bot commented 4 years ago

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

:memo: Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
kubevirt-bot commented 4 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign fabiand You can assign the PR to them by writing /assign @fabiand in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubevirt/demo/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
omeryahud commented 4 years ago

/assign @fabiand

alosadagrande commented 4 years ago

You must sign your commits as are we are recently part of the CNCF.

Also, I would suggest to use a variable otherwise every release would need to be changed.

Something similar has been done in the KubeVirt quickstart lab

You can define the exact version if needed: export KUBEVIRT_VERSION="v0.18.0"

Or you can just obtain or check the latest. For instance on Linux you can obtain it using 'curl' via: export KUBEVIRT_VERSION=$(curl -s https://api.github.com/repos/kubevirt/kubevirt/releases|grep tag_name|sort -V | tail -1 | awk -F':' '{print $2}' | sed 's/,//' | xargs | cut -d'-' -f1)

echo $KUBEVIRT_VERSION

Then:

kubectl create -f https://github.com/kubevirt/kubevirt/releases/download/${KUBEVIRT_VERSION}/kubevirt-operator.yaml