search

kubevirt / demo

Easy to use KubeVirt demo based on minikube.
Apache License 2.0
108 stars 59 forks source link

Improving the static version of KubeVirt to an autodiscovery of the l… #130

Closed ptrnull closed 4 years ago

ptrnull commented 4 years ago

Improving the static version of KubeVirt to an autodiscovery way to avoid updates on the README.md each time a new KubeVirt version is released.

Signed-off-by: Pedro Ibáñez pedro@redhat.com

fabiand commented 4 years ago

I'd like to stick to explicit versions in the demo. Simplicity over diifficult to read.

The other option is to revive the thread about maintaining an repo to point to the latest version of certain "channels". There was a thread on kubevirt-dev on this

ptrnull commented 4 years ago

I'd like to stick to explicit versions in the demo. Simplicity over diifficult to read. The other option is to revive the thread about maintaining an repo to point to the latest version of certain "channels". There was a thread on kubevirt-dev on this

Then, it's done! roll-backed the magic, the static is back updated to v0.25.0. LGTMs and approveds are welcome :)

ptrnull commented 4 years ago

@fabiand it can be merge, right? lgtm & approve welcomes :)

iranzo commented 4 years ago

/lgtm /approve

kubevirt-bot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iranzo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/demo/blob/master/OWNERS)~~ [iranzo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment