kubevirt / demo

Easy to use KubeVirt demo based on minikube.
Apache License 2.0
108 stars 59 forks source link

test: Also test uninstall #131

Closed fabiand closed 4 years ago

fabiand commented 4 years ago

Signed-off-by: Fabian Deutsch fabiand@fedoraproject.org

kubevirt-bot commented 4 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign fabiand You can assign the PR to them by writing /assign @fabiand in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubevirt/demo/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
iranzo commented 4 years ago

Is this intended to test the 'manual uninstall' that should happen when CR is removed?

Ref: https://github.com/kubevirt/user-guide/pull/287

fabiand commented 4 years ago

It should test the uninstall flow that a user is expected to do.

fabiand commented 4 years ago

Right - good point. My working hypothesis until now was that the webhooks got deleted (or rather not) after the api server, which would leave them in a dangling state.

Now I assume that we need to remove the api server and webhook registration efore we delete the api server - to avoid that there are any registration spointing to the api server once it is not around anymore.

iranzo commented 4 years ago

@rmohr @fabiand anything else missing here to get this moving?

rmohr commented 4 years ago

@iranzo I think my last change request is still valid, to first delete the CR.

rmohr commented 4 years ago

btw. with 0.26 this is obsolete.

fabiand commented 4 years ago

@rmohr I actually assumed this as well - so far there still seems to be an issue.

fabiand commented 4 years ago

It's timing out during namespace deletion ...

fabiand commented 4 years ago

It is still timing out:

+kubectl delete -n kubevirt kubevirt kubevirt --wait=true

kubevirt.kubevirt.io "kubevirt" deleted

+kubectl delete namespace kubevirt --wait=true

namespace "kubevirt" deleted

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.

Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#build-times-out-because-no-output-was-received

The build has been terminated

https://travis-ci.org/kubevirt/demo/jobs/652902215#L552

fabiand commented 4 years ago

/approved

fabiand commented 4 years ago

/lgtm

kubevirt-bot commented 4 years ago

@fabiand: you cannot LGTM your own PR.

In response to [this](https://github.com/kubevirt/demo/pull/131#issuecomment-630134882): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
fabiand commented 4 years ago

It works!

fabiand commented 4 years ago

Wohoo