Closed fabiand closed 4 years ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign fabiand
You can assign the PR to them by writing /assign @fabiand
in a comment when ready.
The full list of commands accepted by this bot can be found here.
Is this intended to test the 'manual uninstall' that should happen when CR is removed?
It should test the uninstall flow that a user is expected to do.
Right - good point. My working hypothesis until now was that the webhooks got deleted (or rather not) after the api server, which would leave them in a dangling state.
Now I assume that we need to remove the api server and webhook registration efore we delete the api server - to avoid that there are any registration spointing to the api server once it is not around anymore.
@rmohr @fabiand anything else missing here to get this moving?
@iranzo I think my last change request is still valid, to first delete the CR.
btw. with 0.26 this is obsolete.
@rmohr I actually assumed this as well - so far there still seems to be an issue.
It's timing out during namespace deletion ...
It is still timing out:
+kubectl delete -n kubevirt kubevirt kubevirt --wait=true
kubevirt.kubevirt.io "kubevirt" deleted
+kubectl delete namespace kubevirt --wait=true
namespace "kubevirt" deleted
No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#build-times-out-because-no-output-was-received
The build has been terminated
/approved
/lgtm
@fabiand: you cannot LGTM your own PR.
It works!
Wohoo
Signed-off-by: Fabian Deutsch fabiand@fedoraproject.org