search

kubevirt / demo

Easy to use KubeVirt demo based on minikube.
Apache License 2.0
108 stars 59 forks source link

Adding file of 'CONTRIBUTING.md' and LICENSE for the project #135

Closed lubinszARM closed 4 years ago

lubinszARM commented 4 years ago

Hi, We want to add some ARM64 related descriptions, but there is no 'CONTRIBUTING.md' and LICENSE here, so we are not able to contribute code here. Can you add the files? Example： https://github.com/hustcat/sriov-cni/blob/master/LICENSE https://github.com/hustcat/sriov-cni/blob/master/CONTRIBUTING.md Guideline: https://help.github.com/en/github/building-a-strong-community/setting-guidelines-for-repository-contributors https://help.github.com/en/github/building-a-strong-community/adding-a-license-to-a-repository

lubinszARM commented 4 years ago

cc @kalyxin02

lubinszARM commented 4 years ago

@fabiand @iranzo Any comments? Thanks.

fabiand commented 4 years ago

@lubinszARM Heya! Good idea.

DO you mind opening a PR which is adding those files?

fabiand commented 4 years ago

And: How far did you get to get KubeVirt running on ARM?

lubinszARM commented 4 years ago

Hi @fabiand We can already use kubeadm to deploy kubevirt on Arm64 internally. Also, we are trying to push the PR-s to upstream. Such as: https://github.com/kubevirt/kubevirt/pull/3415

lubinszARM commented 4 years ago

@lubinszARM Heya! Good idea.

DO you mind opening a PR which is adding those files?

Our legal department needs to review these two documents, otherwise we cannot submit PR-s.

fabiand commented 4 years ago

Oh, ok, then let me help you to submit some defaults.

fabiand commented 4 years ago

We can already use kubeadm to deploy kubevirt on Arm64 internally. Also, we are trying to push the PR-s to upstream.

Pretty awesome!

If we want to enable this for kubevirt in releases, then we also need CI (maybe you have some hardware we could use for CI?) - and we also want to add it to the travis ci of this demo. If travis is uspporting arm ..

fabiand commented 4 years ago

Done.