Without custom iso - Githubissues

kubevirt / demo

Easy to use KubeVirt demo based on minikube.

Apache License 2.0

109 stars 59 forks source link

Without custom iso #20

Closed fabiand closed 7 years ago

fabiand commented 7 years ago

minikube v0.22.0 fixes the macvlan problem, thus we can remove the custom iso note.

fabiand commented 7 years ago

$ ./test.sh 
README contains correct version ... OK
VM is running ... OK
VM serial console works ... OK
PASS
$ minikube version
minikube version: v0.22.0

nertpinx commented 7 years ago

I just wanted to leave an approving comment with a nit pick that the minimal version could be mentioned somewhere. But I guess older versions of minikube will bother you with the "newer version is available" anyway =)

fabiand commented 7 years ago

@nertpinx thanks for that hint - I actually thought about a min ver check, but it's nasty to do a vercmp using bash :)

However, it can still be added to the readme.