search

kubevirt / demo

Easy to use KubeVirt demo based on minikube.
Apache License 2.0
109 stars 59 forks source link

Add Minishift demo #55

Closed zvikorn closed 6 years ago

zvikorn commented 6 years ago

Adding description for installing Minishift and Kubevirt on top of that

scollier commented 6 years ago

LGTM

fabiand commented 6 years ago

Awesome!

itamarh commented 6 years ago
  1. great to see this moving forward.
  2. is minishift running in a VM? is it with nested virt or not?
  3. The main readme of this github repo is focused on minikube. So one has to guess there is a minishift sample as well? Either mention it in the beginning of the main readme, or move the minikube to readme-minikube, and have the main one point to both per user's choice?

Thanks!

fabiand commented 6 years ago

great to see this moving forward. is minishift running in a VM? is it with nested virt or not?

Yes, minishift is using a VM as well. No nesting, needs to be fixed in minishift

The main readme of this github repo is focused on minikube. So one has to guess there is a minishift sample as well? Either mention it in the beginning of the main readme, or move the minikube to readme-minikube, and have the main one point to both per user's choice?

Good point, I'll add a cross reference.