search

kubevirt / hostpath-provisioner-operator

Apache License 2.0
52 stars 35 forks source link

Use golang available in builder container instead of trying to set it manually. #433

Closed awels closed 9 months ago

awels commented 9 months ago

What this PR does / why we need it: Setting the version manually was breaking the image release of latest (and possibly branches as well once we make a new one)

Also update the container to build fedora 39 instead of 36.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Release note:

NONE
aglitke commented 9 months ago

/lgtm

aglitke commented 9 months ago

/approve

kubevirt-bot commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aglitke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/hostpath-provisioner-operator/blob/main/OWNERS)~~ [aglitke] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment