search

kubevirt / hostpath-provisioner-operator

Apache License 2.0
52 stars 35 forks source link

Revert to using controller-runtime registry for metrics #439

Closed machadovilaca closed 9 months ago

machadovilaca commented 9 months ago

What this PR does / why we need it:

Before https://github.com/kubevirt/hostpath-provisioner-operator/pull/405, HPO was using controller-runtime metrics registry to register the operator metrics. In that PR, since its using the defaults, it started using Prometheus client-go registry.

This PR reverts to using the controller-runtime metrics

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Release note:

Revert to using controller-runtime registry for metrics
awels commented 9 months ago

/lgtm /approve

kubevirt-bot commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awels

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/hostpath-provisioner-operator/blob/main/OWNERS)~~ [awels] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment