search

kubevirt / hostpath-provisioner-operator

Apache License 2.0
52 stars 35 forks source link

[release-v0.17] fix revive errors #463

Closed awels closed 7 months ago

awels commented 7 months ago

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Release note:

NONE
alromeros commented 7 months ago

/lgtm

awels commented 7 months ago

/approve

kubevirt-bot commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awels

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/hostpath-provisioner-operator/blob/release-v0.17/OWNERS)~~ [awels] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
awels commented 7 months ago

/cherrypick release-v0.16

kubevirt-bot commented 7 months ago

@awels: once the present PR merges, I will cherry-pick it on top of release-v0.16 in a new PR and assign it to you.

In response to [this](https://github.com/kubevirt/hostpath-provisioner-operator/pull/463#issuecomment-2051997338): >/cherrypick release-v0.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
awels commented 7 months ago

/cherrypick release-v0.15

kubevirt-bot commented 7 months ago

@awels: once the present PR merges, I will cherry-pick it on top of release-v0.15 in a new PR and assign it to you.

In response to [this](https://github.com/kubevirt/hostpath-provisioner-operator/pull/463#issuecomment-2051997503): >/cherrypick release-v0.15 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
awels commented 7 months ago

/cherrypick release-v0.14

kubevirt-bot commented 7 months ago

@awels: once the present PR merges, I will cherry-pick it on top of release-v0.14 in a new PR and assign it to you.

In response to [this](https://github.com/kubevirt/hostpath-provisioner-operator/pull/463#issuecomment-2051997603): >/cherrypick release-v0.14 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
kubevirt-bot commented 7 months ago

@awels: new pull request created: #464

In response to [this](https://github.com/kubevirt/hostpath-provisioner-operator/pull/463#issuecomment-2051997338): >/cherrypick release-v0.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
kubevirt-bot commented 7 months ago

@awels: new pull request created: #465

In response to [this](https://github.com/kubevirt/hostpath-provisioner-operator/pull/463#issuecomment-2051997503): >/cherrypick release-v0.15 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
kubevirt-bot commented 7 months ago

@awels: new pull request created: #466

In response to [this](https://github.com/kubevirt/hostpath-provisioner-operator/pull/463#issuecomment-2051997603): >/cherrypick release-v0.14 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.