search

kubevirt / hyperconverged-cluster-operator

Operator pattern for managing multi-operator products
Apache License 2.0
149 stars 150 forks source link

Auto-generated files creation date changes which leads to frequent rebases #2272

Closed iholder101 closed 1 year ago

iholder101 commented 1 year ago

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:

/kind bug /kind enhancement

What happened: Since auto-generated files (e.g. kubevirt-hyperconverged-operator.v1.9.0.clusterserviceversion.yaml) contain creation dates, it means that whenever a new PR generates this file it always causes conflicts and demand rebases

For example:

<<<<<<< HEAD
    createdAt: "2023-02-23 12:59:00"
=======
    createdAt: "2023-02-12 18:30:28"
>>>>>>> c5a554a6f (virt-launcher-mutator: add handleVirtLauncherMemoryHeadroom())

What you expected to happen: Reduce frequent need to rebase

nunnatsa commented 1 year ago

This is only happened if two PRs are changing this file. otherwise, if this is the only change, then the sanity script knows to ignore this line.

This is done in hack/diff-csv.sh that then used by both make sanity and hack/build-manifests.sh

kubevirt-bot commented 1 year ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

kubevirt-bot commented 1 year ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

kubevirt-bot commented 1 year ago

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

/close

kubevirt-bot commented 1 year ago

@kubevirt-bot: Closing this issue.

In response to [this](https://github.com/kubevirt/hyperconverged-cluster-operator/issues/2272#issuecomment-1657172175): >Rotten issues close after 30d of inactivity. >Reopen the issue with `/reopen`. >Mark the issue as fresh with `/remove-lifecycle rotten`. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.