kubevirt / hyperconverged-cluster-operator

Operator pattern for managing multi-operator products
Apache License 2.0
149 stars 150 forks source link

docs: AAQ default namespace selector #2931

Closed iholder101 closed 4 months ago

iholder101 commented 4 months ago

What this PR does / why we need it: Add AAQ docs regarding its default namespace selector. This is reflecting the changes done in https://github.com/kubevirt/application-aware-quota/pull/59.

Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

Jira Ticket:

https://issues.redhat.com/browse/CNV-39880

Release note:

docs: AAQ default namespace selector
iholder101 commented 4 months ago

FYI @Barakmor1 @kbidarkar @acardace

coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 8925879763

Details


Totals Coverage Status
Change from base Build 8924842871: 0.0%
Covered Lines: 5200
Relevant Lines: 6058

💛 - Coveralls
nunnatsa commented 4 months ago

/lgtm /approve

kubevirt-bot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/hyperconverged-cluster-operator/blob/main/OWNERS)~~ [nunnatsa] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
Barakmor1 commented 4 months ago

/hold Maybe lets mentioned the spec.nodeName limitation

Please feel free to unhlod.

iholder101 commented 4 months ago

/hold Maybe lets mentioned the spec.nodeName limitation

Please feel free to unhlod.

Done! /unhold

Barakmor1 commented 4 months ago

/lgtm

sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Barakmor1 commented 4 months ago

/lgtm