search

kubevirt / hyperconverged-cluster-operator

Operator pattern for managing multi-operator products
Apache License 2.0
149 stars 150 forks source link

Adding Aviv and Assaf as approvers of HCO #2956

Closed orenc1 closed 4 months ago

orenc1 commented 4 months ago

What this PR does / why we need it:

Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

Jira Ticket:

NONE

Release note:

NONE
sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 9001735120

Details

Files with Coverage Reduction New Missed Lines %
controllers/operands/operandHandler.go 1 86.18%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 9000371846: -0.02%
Covered Lines: 5200
Relevant Lines: 6058
💛 - Coveralls
tiraboschi commented 4 months ago

/lgtm

orenc1 commented 4 months ago

/retest

sradco commented 4 months ago

/approve

kubevirt-bot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sradco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/hyperconverged-cluster-operator/blob/main/OWNERS)~~ [sradco] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
orenc1 commented 4 months ago

/test okd-images

kubevirt-bot commented 4 months ago

@orenc1: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

Use /test all to run the following jobs that were automatically triggered:

In response to [this](https://github.com/kubevirt/hyperconverged-cluster-operator/pull/2956#issuecomment-2101255574): >/test okd-images Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
orenc1 commented 4 months ago

/cherry-pick release-1.12 /cherry-pick release-1.11

kubevirt-bot commented 4 months ago

@orenc1: new pull request created: #2960

In response to [this](https://github.com/kubevirt/hyperconverged-cluster-operator/pull/2956#issuecomment-2102197428): >/cherry-pick release-1.12 >/cherry-pick release-1.11 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
orenc1 commented 4 months ago

/cherry-pick release-1.11

kubevirt-bot commented 4 months ago

@orenc1: new pull request created: #2961

In response to [this](https://github.com/kubevirt/hyperconverged-cluster-operator/pull/2956#issuecomment-2102199994): >/cherry-pick release-1.11 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.