search

kubevirt / hyperconverged-cluster-operator

Operator pattern for managing multi-operator products
Apache License 2.0
154 stars 152 forks source link

[release-1.11] Adding Aviv and Assaf as approvers of HCO #2961

Closed kubevirt-bot closed 2 months ago

kubevirt-bot commented 5 months ago

This is an automated cherry-pick of #2956

/assign orenc1

NONE
kubevirt-bot commented 5 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from orenc1. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubevirt/hyperconverged-cluster-operator/blob/release-1.11/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sonarcloud[bot] commented 5 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 9014586464

Details

Totals Coverage Status
Change from base Build 8960753074: 0.02%
Covered Lines: 5417
Relevant Lines: 6252
💛 - Coveralls
kubevirt-bot commented 5 months ago

@kubevirt-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-hyperconverged-cluster-operator-e2e-k8s-1.27 09a07688f0e6cd352a8112f0a8ac28b2747885b9 link true /test pull-hyperconverged-cluster-operator-e2e-k8s-1.27
Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
sradco commented 5 months ago

/lgtm

nunnatsa commented 5 months ago

@orenc1 why do we need this pr? The permissions are taken from main, iiuc

nunnatsa commented 5 months ago

/hold