search

kubevirt / hyperconverged-cluster-operator

Operator pattern for managing multi-operator products
Apache License 2.0
154 stars 152 forks source link

dataImportCronTemplates: Remove instancetype.kubevirt.io labels #2964

Closed lyarwood closed 4 months ago

lyarwood commented 5 months ago

What this PR does / why we need it:

This metadata is now provided by the containerdisks project for these imports and used by CDI to later populate the required labels on the resulting PVCs:

$ podman image inspect quay.io/containerdisks/centos-stream:8 | jq '.[] | .Config.Env'
[
  "INSTANCETYPE_KUBEVIRT_IO_DEFAULT_INSTANCETYPE=u1.medium",
  "INSTANCETYPE_KUBEVIRT_IO_DEFAULT_PREFERENCE=centos.stream8"
]
$ ./cluster-up/kubectl.sh apply -f -<<EOF
apiVersion: cdi.kubevirt.io/v1beta1
kind: DataImportCron
metadata:
  annotations:
    cdi.kubevirt.io/storage.bind.immediate.requested: "true"
  name: centos-stream8-image-cron
spec:
  schedule: "0 */12 * * *"
  template:
    spec:
      source:
        registry:
          url: docker://quay.io/containerdisks/centos-stream:8
      storage:
        resources:
          requests:
            storage: 10Gi
  garbageCollect: Outdated
  managedDataSource: centos-stream8
EOF
[..]
./cluster-up/kubectl.sh get dv
selecting podman as container runtime
NAME                          PHASE       PROGRESS   RESTARTS   AGE
centos-stream8-d06927f5ae68   Succeeded   100.0%                61s
[..]
./cluster-up/kubectl.sh get pvc/centos-stream8-d06927f5ae68 -o json | jq .metadata.labels 
selecting podman as container runtime
{
  "alerts.k8s.io/KubePersistentVolumeFillingUp": "disabled",
  "app": "containerized-data-importer",
  "app.kubernetes.io/component": "storage",
  "app.kubernetes.io/managed-by": "cdi-controller",
  "cdi.kubevirt.io/dataImportCron": "centos-stream8-image-cron",
  "instancetype.kubevirt.io/default-instancetype": "u1.medium",
  "instancetype.kubevirt.io/default-preference": "centos.stream8"
}

$ ./cluster-up/kubectl.sh apply -k https://github.com/kubevirt/common-instancetypes.git
[..]
./cluster-up/virtctl.sh create vm --volume-import type:pvc,size:10Gi,src:default/centos-stream8-d06927f5ae68  --infer-instancetype --infer-preference --cloud-init-user-data $USER_DATA --name centos | ./cluster-up/kubectl.sh apply -f -
[..]
./cluster-up/kubectl.sh get vm/centos -o json | jq '.spec |.instancetype,.preference'
selecting podman as container runtime
{
  "kind": "virtualmachineclusterinstancetype",
  "name": "u1.medium",
  "revisionName": "centos-u1.medium-9af4814d-f78a-458c-b3d1-2b60d64bfcf6-1"
}
{
  "kind": "virtualmachineclusterpreference",
  "name": "centos.stream8",
  "revisionName": "centos-centos.stream8-7a5e492e-bac0-4e73-878a-aa88564d0803-1"
}

./cluster-up/kubectl.sh delete vms/centos

./cluster-up/virtctl.sh create vm --volume-datasource src:centos-stream8,name:centos,size:10Gi  --infer-instancetype --infer-preference --cloud-init-user-data $USER_DATA --name centos | ./cluster-up/kubectl.sh apply -f -
[..]
./cluster-up/kubectl.sh get vm/centos -o json | jq '.spec |.instancetype,.preference'
selecting podman as container runtime
{
  "kind": "virtualmachineclusterinstancetype",
  "name": "u1.medium",
  "revisionName": "centos-u1.medium-9af4814d-f78a-458c-b3d1-2b60d64bfcf6-1"
}
{
  "kind": "virtualmachineclusterpreference",
  "name": "centos.stream8",
  "revisionName": "centos-centos.stream8-7a5e492e-bac0-4e73-878a-aa88564d0803-1"
}

Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

Jira Ticket:

https://issues.redhat.com/browse/CNV-41767

Release note:

NONE
kubevirt-bot commented 5 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] commented 5 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

sonarcloud[bot] commented 5 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.7% Duplication on New Code

See analysis details on SonarCloud

lyarwood commented 5 months ago

/cc @0xFelix

lyarwood commented 4 months ago

Thanks @0xFelix, @nunnatsa this should be ready to review now if you have time.

lyarwood commented 4 months ago

/retest-required

openshift-ci[bot] commented 4 months ago

@lyarwood: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/hco-e2e-operator-sdk-sno-aws f3434d63b8c2fdc15fbe440190e06c915a690ff3 link false /test hco-e2e-operator-sdk-sno-aws
ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-aws f3434d63b8c2fdc15fbe440190e06c915a690ff3 link false /test hco-e2e-upgrade-prev-operator-sdk-sno-aws
ci/prow/hco-e2e-upgrade-operator-sdk-sno-aws f3434d63b8c2fdc15fbe440190e06c915a690ff3 link false /test hco-e2e-upgrade-operator-sdk-sno-aws
ci/prow/hco-e2e-kv-smoke-azure f3434d63b8c2fdc15fbe440190e06c915a690ff3 link true /test hco-e2e-kv-smoke-azure
ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-aws f3434d63b8c2fdc15fbe440190e06c915a690ff3 link true /test hco-e2e-consecutive-operator-sdk-upgrades-aws
ci/prow/hco-e2e-upgrade-operator-sdk-aws f3434d63b8c2fdc15fbe440190e06c915a690ff3 link true /test hco-e2e-upgrade-operator-sdk-aws
ci/prow/hco-e2e-upgrade-prev-operator-sdk-aws f3434d63b8c2fdc15fbe440190e06c915a690ff3 link true /test hco-e2e-upgrade-prev-operator-sdk-aws
ci/prow/hco-e2e-operator-sdk-aws f3434d63b8c2fdc15fbe440190e06c915a690ff3 link true /test hco-e2e-operator-sdk-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
hco-bot commented 4 months ago

hco-e2e-operator-sdk-azure lane succeeded. /override ci/prow/hco-e2e-operator-sdk-aws hco-e2e-upgrade-prev-operator-sdk-azure lane succeeded. /override ci/prow/hco-e2e-upgrade-prev-operator-sdk-aws hco-e2e-upgrade-operator-sdk-azure lane succeeded. /override ci/prow/hco-e2e-upgrade-operator-sdk-aws hco-e2e-consecutive-operator-sdk-upgrades-azure lane succeeded. /override ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-aws hco-e2e-kv-smoke-gcp lane succeeded. /override ci/prow/hco-e2e-kv-smoke-azure hco-e2e-upgrade-operator-sdk-sno-azure lane succeeded. /override ci/prow/hco-e2e-upgrade-operator-sdk-sno-aws hco-e2e-upgrade-prev-operator-sdk-sno-azure lane succeeded. /override ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-aws

hco-bot commented 4 months ago

hco-e2e-operator-sdk-azure lane succeeded. /override ci/prow/hco-e2e-operator-sdk-aws hco-e2e-upgrade-prev-operator-sdk-azure lane succeeded. /override ci/prow/hco-e2e-upgrade-prev-operator-sdk-aws hco-e2e-upgrade-operator-sdk-azure lane succeeded. /override ci/prow/hco-e2e-upgrade-operator-sdk-aws hco-e2e-consecutive-operator-sdk-upgrades-azure lane succeeded. /override ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-aws hco-e2e-kv-smoke-gcp lane succeeded. /override ci/prow/hco-e2e-kv-smoke-azure hco-e2e-upgrade-operator-sdk-sno-azure lane succeeded. /override ci/prow/hco-e2e-upgrade-operator-sdk-sno-aws hco-e2e-upgrade-prev-operator-sdk-sno-azure lane succeeded. /override ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-aws

kubevirt-bot commented 4 months ago

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-aws, ci/prow/hco-e2e-kv-smoke-azure, ci/prow/hco-e2e-operator-sdk-aws, ci/prow/hco-e2e-upgrade-operator-sdk-aws, ci/prow/hco-e2e-upgrade-operator-sdk-sno-aws, ci/prow/hco-e2e-upgrade-prev-operator-sdk-aws, ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-aws

In response to [this](https://github.com/kubevirt/hyperconverged-cluster-operator/pull/2964#issuecomment-2151903259): >hco-e2e-operator-sdk-azure lane succeeded. >/override ci/prow/hco-e2e-operator-sdk-aws >hco-e2e-upgrade-prev-operator-sdk-azure lane succeeded. >/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-aws >hco-e2e-upgrade-operator-sdk-azure lane succeeded. >/override ci/prow/hco-e2e-upgrade-operator-sdk-aws >hco-e2e-consecutive-operator-sdk-upgrades-azure lane succeeded. >/override ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-aws >hco-e2e-kv-smoke-gcp lane succeeded. >/override ci/prow/hco-e2e-kv-smoke-azure >hco-e2e-upgrade-operator-sdk-sno-azure lane succeeded. >/override ci/prow/hco-e2e-upgrade-operator-sdk-sno-aws >hco-e2e-upgrade-prev-operator-sdk-sno-azure lane succeeded. >/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-aws > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
kubevirt-bot commented 4 months ago

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-aws, ci/prow/hco-e2e-kv-smoke-azure, ci/prow/hco-e2e-operator-sdk-aws, ci/prow/hco-e2e-upgrade-operator-sdk-aws, ci/prow/hco-e2e-upgrade-operator-sdk-sno-aws, ci/prow/hco-e2e-upgrade-prev-operator-sdk-aws, ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-aws

In response to [this](https://github.com/kubevirt/hyperconverged-cluster-operator/pull/2964#issuecomment-2151903426): >hco-e2e-operator-sdk-azure lane succeeded. >/override ci/prow/hco-e2e-operator-sdk-aws >hco-e2e-upgrade-prev-operator-sdk-azure lane succeeded. >/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-aws >hco-e2e-upgrade-operator-sdk-azure lane succeeded. >/override ci/prow/hco-e2e-upgrade-operator-sdk-aws >hco-e2e-consecutive-operator-sdk-upgrades-azure lane succeeded. >/override ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-aws >hco-e2e-kv-smoke-gcp lane succeeded. >/override ci/prow/hco-e2e-kv-smoke-azure >hco-e2e-upgrade-operator-sdk-sno-azure lane succeeded. >/override ci/prow/hco-e2e-upgrade-operator-sdk-sno-aws >hco-e2e-upgrade-prev-operator-sdk-sno-azure lane succeeded. >/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-aws > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
nunnatsa commented 4 months ago

/approve /override-bot

kubevirt-bot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/hyperconverged-cluster-operator/blob/main/OWNERS)~~ [nunnatsa] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
nunnatsa commented 4 months ago

hco-e2e-operator-sdk-sno-azure lane passed /override ci/prow/hco-e2e-operator-sdk-sno-aws

kubevirt-bot commented 4 months ago

@nunnatsa: Overrode contexts on behalf of nunnatsa: ci/prow/hco-e2e-operator-sdk-sno-aws

In response to [this](https://github.com/kubevirt/hyperconverged-cluster-operator/pull/2964#issuecomment-2158014917): >hco-e2e-operator-sdk-sno-azure lane passed >/override ci/prow/hco-e2e-operator-sdk-sno-aws Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.