kubevirt / hyperconverged-cluster-operator

Operator pattern for managing multi-operator products
Apache License 2.0
145 stars 148 forks source link

Use nmap from the OS packages #2978

Closed tiraboschi closed 1 month ago

tiraboschi commented 1 month ago

What this PR does / why we need it: In the past we had to force the usage of a fresher upstream nmap rpm. Now we can avoid this.

Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

Jira Ticket:

NONE

Release note:

NONE
coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 9285356048

Details


Totals Coverage Status
Change from base Build 9188449790: 0.0%
Covered Lines: 5199
Relevant Lines: 6059

💛 - Coveralls
sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

kubevirt-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/hyperconverged-cluster-operator/blob/main/OWNERS)~~ [nunnatsa] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
nunnatsa commented 1 month ago

/retest

openshift-ci[bot] commented 1 month ago

@tiraboschi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/hco-e2e-operator-sdk-gcp fc869188832edcc9139cf24309994f2c752df7c1 link true /test hco-e2e-operator-sdk-gcp
ci/prow/hco-e2e-operator-sdk-sno-azure fc869188832edcc9139cf24309994f2c752df7c1 link false /test hco-e2e-operator-sdk-sno-azure
ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure fc869188832edcc9139cf24309994f2c752df7c1 link false /test hco-e2e-upgrade-operator-sdk-sno-azure
ci/prow/hco-e2e-operator-sdk-azure fc869188832edcc9139cf24309994f2c752df7c1 link true /test hco-e2e-operator-sdk-azure
ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure fc869188832edcc9139cf24309994f2c752df7c1 link false /test hco-e2e-upgrade-prev-operator-sdk-sno-azure
ci/prow/hco-e2e-upgrade-prev-operator-sdk-azure fc869188832edcc9139cf24309994f2c752df7c1 link true /test hco-e2e-upgrade-prev-operator-sdk-azure
ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-azure fc869188832edcc9139cf24309994f2c752df7c1 link true /test hco-e2e-consecutive-operator-sdk-upgrades-azure
ci/prow/hco-e2e-upgrade-operator-sdk-azure fc869188832edcc9139cf24309994f2c752df7c1 link true /test hco-e2e-upgrade-operator-sdk-azure
ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-aws fc869188832edcc9139cf24309994f2c752df7c1 link false /test hco-e2e-upgrade-prev-operator-sdk-sno-aws
ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-aws fc869188832edcc9139cf24309994f2c752df7c1 link true /test hco-e2e-consecutive-operator-sdk-upgrades-aws
ci/prow/hco-e2e-operator-sdk-aws fc869188832edcc9139cf24309994f2c752df7c1 link true /test hco-e2e-operator-sdk-aws
ci/prow/hco-e2e-operator-sdk-sno-aws fc869188832edcc9139cf24309994f2c752df7c1 link false /test hco-e2e-operator-sdk-sno-aws
ci/prow/hco-e2e-upgrade-operator-sdk-sno-aws fc869188832edcc9139cf24309994f2c752df7c1 link false /test hco-e2e-upgrade-operator-sdk-sno-aws
ci/prow/hco-e2e-upgrade-prev-operator-sdk-aws fc869188832edcc9139cf24309994f2c752df7c1 link true /test hco-e2e-upgrade-prev-operator-sdk-aws
ci/prow/hco-e2e-upgrade-operator-sdk-aws fc869188832edcc9139cf24309994f2c752df7c1 link true /test hco-e2e-upgrade-operator-sdk-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
tiraboschi commented 1 month ago

bad attempt