[release-1.12] Enable VM live update rollout strategy always

[tiraboschi]

What this PR does / why we need it: This PR enables the KubeVirt VM rollout strategy LiveUpdate, allowing changes to VM specs to dynamically propagate to their VMI. Rollout strategy LiveUpdate is enabled using VMLiveUpdateFeatures Feature Gate and not a configuration knob. This because, from Kubevirt side, the feature is still protected by a FG, therefore it is still considered not stable in all the contexts and can potentially 1) be dropped, 2) changed in a breaking manner. So the FeatureGate is still there and no configuration knob is exposed. Nevertheless, according to the results of our tests, we can consider it as suitable for this use case and so we can handle it as part of the HCO opinionated deployment. Eventual breaking changes will be evaluated and handled on the HCO side when consuming a future version of Kubevirt.

Kubevirt test_id:6867 is currently broken, it will be fixed with kubevirt/kubevirt#12073 It's not a blocker/critical issue so we can temporarely tolerate it. The test will be enabled back when we will be able to consume a newer and fixed Kubevirt release.

Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

• [ ] PR Message
• [ ] Commit Messages
• [ ] How to test
• [ ] Unit Tests
• [ ] Functional Tests
• [ ] User Documentation
• [ ] Developer Documentation
• [ ] Upgrade Scenario
• [ ] Uninstallation Scenario
• [ ] Backward Compatibility
• [ ] Troubleshooting Friendly

Jira Ticket:

https://issues.redhat.com/browse/CNV-36370

Release note:

KubeVirt VM rollout strategy LiveUpdate is now always enabled

[coveralls]

Pull Request Test Coverage Report for Build 9401130894

Details

• 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.002%) to 85.839%

---

Totals
Change from base Build 9304527410:	0.002%
Covered Lines:	5201
Relevant Lines:	6059

---

💛 - Coveralls

[tiraboschi]

/hold waiting for https://github.com/kubevirt/hyperconverged-cluster-operator/pull/2984 first

[tiraboschi]

/retest

[kubevirt-bot]

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubevirt/hyperconverged-cluster-operator/blob/release-1.12/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

[tiraboschi]

/unhold

[acardace]

/lgtm

[acardace]

/retest

[tiraboschi]

/retest

[tiraboschi]

/override-bot

[hco-bot]

hco-e2e-upgrade-operator-sdk-sno-azure lane succeeded. /override ci/prow/hco-e2e-upgrade-operator-sdk-sno-aws

[hco-bot]

hco-e2e-upgrade-operator-sdk-sno-azure lane succeeded. /override ci/prow/hco-e2e-upgrade-operator-sdk-sno-aws

[kubevirt-bot]

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-operator-sdk-sno-aws

In response to [this](https://github.com/kubevirt/hyperconverged-cluster-operator/pull/2986#issuecomment-2154232955): >hco-e2e-upgrade-operator-sdk-sno-azure lane succeeded. >/override ci/prow/hco-e2e-upgrade-operator-sdk-sno-aws > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

[kubevirt-bot]

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-operator-sdk-sno-aws

In response to [this](https://github.com/kubevirt/hyperconverged-cluster-operator/pull/2986#issuecomment-2154233015): >hco-e2e-upgrade-operator-sdk-sno-azure lane succeeded. >/override ci/prow/hco-e2e-upgrade-operator-sdk-sno-aws > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

[tiraboschi]

/override-bot

[tiraboschi]

hco-e2e-operator-sdk-azure lane succeeded. /override ci/prow/hco-e2e-operator-sdk-aws

hco-e2e-operator-sdk-sno-azure lane succeeded. /override ci/prow/hco-e2e-operator-sdk-sno-aws

hco-e2e-upgrade-operator-sdk-azure lane succeeded. /override ci/prow/hco-e2e-upgrade-operator-sdk-aws

hco-e2e-upgrade-prev-operator-sdk-azure lane succeeded. /override ci/prow/hco-e2e-upgrade-prev-operator-sdk-aws

hco-e2e-upgrade-prev-operator-sdk-sno-azure lane succeeded. /override ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-aws

[kubevirt-bot]

@tiraboschi: Overrode contexts on behalf of tiraboschi: ci/prow/hco-e2e-operator-sdk-aws, ci/prow/hco-e2e-operator-sdk-sno-aws, ci/prow/hco-e2e-upgrade-operator-sdk-aws, ci/prow/hco-e2e-upgrade-prev-operator-sdk-aws, ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-aws

In response to [this](https://github.com/kubevirt/hyperconverged-cluster-operator/pull/2986#issuecomment-2154323247): >hco-e2e-operator-sdk-azure lane succeeded. >/override ci/prow/hco-e2e-operator-sdk-aws > >hco-e2e-operator-sdk-sno-azure lane succeeded. >/override ci/prow/hco-e2e-operator-sdk-sno-aws > >hco-e2e-upgrade-operator-sdk-azure lane succeeded. >/override ci/prow/hco-e2e-upgrade-operator-sdk-aws > >hco-e2e-upgrade-prev-operator-sdk-azure lane succeeded. >/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-aws > >hco-e2e-upgrade-prev-operator-sdk-sno-azure lane succeeded. >/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-aws Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

[tiraboschi]

/retest

[acardace]

@tiraboschi can you override the smoke tests? The failing test will be fixed by https://github.com/kubevirt/kubevirt/pull/12073 but no new release will be cut.

[sonarcloud[bot]]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[coveralls]

Pull Request Test Coverage Report for Build 9415312616

Details

• 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
• 1 unchanged line in 1 file lost coverage.
• Overall coverage decreased (-0.01%) to 85.839%

---

Files with Coverage Reduction	New Missed Lines	%
controllers/operands/operandHandler.go	1	86.18%
<!--	Total:	1		-->

Totals
Change from base Build 9403838831:	-0.01%
Covered Lines:	5201
Relevant Lines:	6059

---

💛 - Coveralls

[acardace]

/lgtm

[tiraboschi]

/retest

[tiraboschi]

/override-bot

[hco-bot]

hco-e2e-kv-smoke-gcp lane succeeded. /override ci/prow/hco-e2e-kv-smoke-azure hco-e2e-upgrade-operator-sdk-azure lane succeeded. /override ci/prow/hco-e2e-upgrade-operator-sdk-aws hco-e2e-upgrade-prev-operator-sdk-sno-azure lane succeeded. /override ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-aws hco-e2e-upgrade-prev-operator-sdk-azure lane succeeded. /override ci/prow/hco-e2e-upgrade-prev-operator-sdk-aws hco-e2e-operator-sdk-azure, hco-e2e-operator-sdk-gcp lanes succeeded. /override ci/prow/hco-e2e-operator-sdk-aws

[kubevirt-bot]

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-azure, ci/prow/hco-e2e-operator-sdk-aws, ci/prow/hco-e2e-upgrade-operator-sdk-aws, ci/prow/hco-e2e-upgrade-prev-operator-sdk-aws, ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-aws

In response to [this](https://github.com/kubevirt/hyperconverged-cluster-operator/pull/2986#issuecomment-2154949611): >hco-e2e-kv-smoke-gcp lane succeeded. >/override ci/prow/hco-e2e-kv-smoke-azure >hco-e2e-upgrade-operator-sdk-azure lane succeeded. >/override ci/prow/hco-e2e-upgrade-operator-sdk-aws >hco-e2e-upgrade-prev-operator-sdk-sno-azure lane succeeded. >/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-aws >hco-e2e-upgrade-prev-operator-sdk-azure lane succeeded. >/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-aws >hco-e2e-operator-sdk-azure, hco-e2e-operator-sdk-gcp lanes succeeded. >/override ci/prow/hco-e2e-operator-sdk-aws > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

[tiraboschi]

/retest

[tiraboschi]

/retest

[tiraboschi]

hco-e2e-operator-sdk-sno-azure lane succeeded. /override ci/prow/hco-e2e-operator-sdk-sno-aws

[kubevirt-bot]

@tiraboschi: Overrode contexts on behalf of tiraboschi: ci/prow/hco-e2e-operator-sdk-sno-aws

In response to [this](https://github.com/kubevirt/hyperconverged-cluster-operator/pull/2986#issuecomment-2155638308): >hco-e2e-operator-sdk-sno-azure lane succeeded. >/override ci/prow/hco-e2e-operator-sdk-sno-aws Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

[tiraboschi]

/retest

[openshift-ci[bot]]

@tiraboschi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/hco-e2e-operator-sdk-aws	383f6e986c5eda6bd090204d71f66ccb378caeba	link	true	/test hco-e2e-operator-sdk-aws
ci/prow/hco-e2e-upgrade-prev-operator-sdk-aws	383f6e986c5eda6bd090204d71f66ccb378caeba	link	true	/test hco-e2e-upgrade-prev-operator-sdk-aws
ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-aws	383f6e986c5eda6bd090204d71f66ccb378caeba	link	false	/test hco-e2e-upgrade-prev-operator-sdk-sno-aws
ci/prow/hco-e2e-upgrade-operator-sdk-aws	383f6e986c5eda6bd090204d71f66ccb378caeba	link	true	/test hco-e2e-upgrade-operator-sdk-aws
ci/prow/hco-e2e-kv-smoke-azure	383f6e986c5eda6bd090204d71f66ccb378caeba	link	true	/test hco-e2e-kv-smoke-azure
ci/prow/hco-e2e-operator-sdk-sno-aws	383f6e986c5eda6bd090204d71f66ccb378caeba	link	false	/test hco-e2e-operator-sdk-sno-aws
ci/prow/hco-e2e-upgrade-operator-sdk-sno-aws	383f6e986c5eda6bd090204d71f66ccb378caeba	link	false	/test hco-e2e-upgrade-operator-sdk-sno-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

[tiraboschi]

hco-e2e-upgrade-operator-sdk-sno-azure lane succeeded. /override ci/prow/hco-e2e-upgrade-operator-sdk-sno-aws

[kubevirt-bot]

@tiraboschi: Overrode contexts on behalf of tiraboschi: ci/prow/hco-e2e-upgrade-operator-sdk-sno-aws

In response to [this](https://github.com/kubevirt/hyperconverged-cluster-operator/pull/2986#issuecomment-2155857372): >hco-e2e-upgrade-operator-sdk-sno-azure lane succeeded. >/override ci/prow/hco-e2e-upgrade-operator-sdk-sno-aws Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.