search

kubevirt / hyperconverged-cluster-operator

Operator pattern for managing multi-operator products
Apache License 2.0
145 stars 148 forks source link

Extend permittedHostDevices for USB devices #3003

Closed tiraboschi closed 1 month ago

tiraboschi commented 1 month ago

What this PR does / why we need it: Extend permittedHostDevices API with usbHostDevices objects. Add unit tests.

Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

Jira Ticket:

NONE

Release note:

Extend permittedHostDevices for USB devices
coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 9566703025

Details

Totals Coverage Status
Change from base Build 9516168837: 0.05%
Covered Lines: 5219
Relevant Lines: 6080
💛 - Coveralls
coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 9567174985

Details

Totals Coverage Status
Change from base Build 9516168837: 0.05%
Covered Lines: 5219
Relevant Lines: 6080
💛 - Coveralls
openshift-ci[bot] commented 1 month ago

@tiraboschi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/hco-e2e-upgrade-operator-sdk-aws 9ea3bc24f6db55612fb247ee0c6c64cd535c2336 link true /test hco-e2e-upgrade-operator-sdk-aws
ci/prow/hco-e2e-operator-sdk-sno-aws 9ea3bc24f6db55612fb247ee0c6c64cd535c2336 link false /test hco-e2e-operator-sdk-sno-aws
ci/prow/hco-e2e-upgrade-prev-operator-sdk-aws 9ea3bc24f6db55612fb247ee0c6c64cd535c2336 link true /test hco-e2e-upgrade-prev-operator-sdk-aws
ci/prow/hco-e2e-upgrade-operator-sdk-sno-aws 9ea3bc24f6db55612fb247ee0c6c64cd535c2336 link false /test hco-e2e-upgrade-operator-sdk-sno-aws
ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-azure 9ea3bc24f6db55612fb247ee0c6c64cd535c2336 link true /test hco-e2e-consecutive-operator-sdk-upgrades-azure

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
tiraboschi commented 1 month ago

/override-bot

hco-bot commented 1 month ago

hco-e2e-upgrade-prev-operator-sdk-azure lane succeeded. /override ci/prow/hco-e2e-upgrade-prev-operator-sdk-aws hco-e2e-upgrade-operator-sdk-azure lane succeeded. /override ci/prow/hco-e2e-upgrade-operator-sdk-aws hco-e2e-consecutive-operator-sdk-upgrades-aws lane succeeded. /override ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-azure hco-e2e-operator-sdk-sno-azure lane succeeded. /override ci/prow/hco-e2e-operator-sdk-sno-aws hco-e2e-upgrade-operator-sdk-sno-azure lane succeeded. /override ci/prow/hco-e2e-upgrade-operator-sdk-sno-aws

kubevirt-bot commented 1 month ago

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-azure, ci/prow/hco-e2e-operator-sdk-sno-aws, ci/prow/hco-e2e-upgrade-operator-sdk-aws, ci/prow/hco-e2e-upgrade-operator-sdk-sno-aws, ci/prow/hco-e2e-upgrade-prev-operator-sdk-aws

In response to [this](https://github.com/kubevirt/hyperconverged-cluster-operator/pull/3003#issuecomment-2176645009): >hco-e2e-upgrade-prev-operator-sdk-azure lane succeeded. >/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-aws >hco-e2e-upgrade-operator-sdk-azure lane succeeded. >/override ci/prow/hco-e2e-upgrade-operator-sdk-aws >hco-e2e-consecutive-operator-sdk-upgrades-aws lane succeeded. >/override ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-azure >hco-e2e-operator-sdk-sno-azure lane succeeded. >/override ci/prow/hco-e2e-operator-sdk-sno-aws >hco-e2e-upgrade-operator-sdk-sno-azure lane succeeded. >/override ci/prow/hco-e2e-upgrade-operator-sdk-sno-aws > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
kubevirt-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/hyperconverged-cluster-operator/blob/main/OWNERS)~~ [nunnatsa] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tiraboschi commented 1 month ago

/test pull-hyperconverged-cluster-operator-e2e-k8s-1.29

openshift-ci[bot] commented 1 month ago

@tiraboschi: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

The following commands are available to trigger optional jobs:

Use /test all to run the following jobs that were automatically triggered:

In response to [this](https://github.com/kubevirt/hyperconverged-cluster-operator/pull/3003#issuecomment-2178039662): >/test pull-hyperconverged-cluster-operator-e2e-k8s-1.29 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.