[release-1.12] Extend permittedHostDevices for USB devices

tiraboschi commented 1 month ago

What this PR does / why we need it: Extend permittedHostDevices API with usbHostDevices objects. Add unit tests.

This is just a manual cherry-pick of https://github.com/kubevirt/hyperconverged-cluster-operator/pull/3003/

Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

[x] PR Message
[x] Commit Messages
[ ] How to test
[x] Unit Tests
[ ] Functional Tests
[x] User Documentation
[ ] Developer Documentation
[ ] Upgrade Scenario
[ ] Uninstallation Scenario
[x] Backward Compatibility
[ ] Troubleshooting Friendly

Jira Ticket:

NONE

Release note:

Extend permittedHostDevices for USB devices

tiraboschi commented 1 month ago

really late API change /hold

kubevirt-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from tiraboschi. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubevirt/hyperconverged-cluster-operator/blob/release-1.12/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 9579270517

Details

20 of 20 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.06%) to 85.902%

Totals
Change from base Build 9483902455:	0.06%
Covered Lines:	5222
Relevant Lines:	6079

💛 - Coveralls

openshift-ci[bot] commented 1 month ago

@tiraboschi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/hco-e2e-upgrade-operator-sdk-sno-aws	1939e80bcdd38c40b424e6576db88231133a56eb	link	false	`/test hco-e2e-upgrade-operator-sdk-sno-aws`
ci/prow/hco-e2e-upgrade-prev-operator-sdk-azure	1939e80bcdd38c40b424e6576db88231133a56eb	link	true	`/test hco-e2e-upgrade-prev-operator-sdk-azure`
ci/prow/ci-index-hco-bundle	1939e80bcdd38c40b424e6576db88231133a56eb	link	true	`/test ci-index-hco-bundle`
ci/prow/hco-e2e-kv-smoke-gcp	1939e80bcdd38c40b424e6576db88231133a56eb	link	true	`/test hco-e2e-kv-smoke-gcp`
ci/prow/hco-e2e-operator-sdk-gcp	1939e80bcdd38c40b424e6576db88231133a56eb	link	true	`/test hco-e2e-operator-sdk-gcp`
ci/prow/hco-e2e-upgrade-operator-sdk-azure	1939e80bcdd38c40b424e6576db88231133a56eb	link	true	`/test hco-e2e-upgrade-operator-sdk-azure`
ci/prow/images	1939e80bcdd38c40b424e6576db88231133a56eb	link	true	`/test images`
ci/prow/hco-e2e-kv-smoke-azure	1939e80bcdd38c40b424e6576db88231133a56eb	link	true	`/test hco-e2e-kv-smoke-azure`
ci/prow/ci-index-hco-upgrade-operator-sdk-bundle	1939e80bcdd38c40b424e6576db88231133a56eb	link	true	`/test ci-index-hco-upgrade-operator-sdk-bundle`
ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure	1939e80bcdd38c40b424e6576db88231133a56eb	link	false	`/test hco-e2e-upgrade-prev-operator-sdk-sno-azure`
ci/prow/hco-e2e-operator-sdk-azure	1939e80bcdd38c40b424e6576db88231133a56eb	link	true	`/test hco-e2e-operator-sdk-azure`
ci/prow/hco-e2e-operator-sdk-sno-azure	1939e80bcdd38c40b424e6576db88231133a56eb	link	false	`/test hco-e2e-operator-sdk-sno-azure`
ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure	1939e80bcdd38c40b424e6576db88231133a56eb	link	false	`/test hco-e2e-upgrade-operator-sdk-sno-azure`
ci/prow/hco-e2e-operator-sdk-aws	1939e80bcdd38c40b424e6576db88231133a56eb	link	true	`/test hco-e2e-operator-sdk-aws`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

tiraboschi commented 1 month ago

too late in the game, let's close this

kubevirt / hyperconverged-cluster-operator