search

kubevirt / hyperconverged-cluster-operator

Operator pattern for managing multi-operator products
Apache License 2.0
145 stars 148 forks source link

CNAO, KubevirtIpamController: Support component by a feature gate #3006

Closed oshoval closed 1 month ago

oshoval commented 1 month ago

What this PR does / why we need it:

KubevirtIpamController allows having persistent IPs for Kubevirt VM user defined networks. OVN k8s implements the SDN side, hence required to be deployed as well. FG name deployKubevirtIpamController.

Since the feature is alpha, this PR presents a feature gate flag, allows installing the component via CNAO (default value is false). The feature is also feature gated on OCP itself [1].

Note that if used on K8s cluster (non OCP), a cert manager is required to be deployed, cert-manager is recommended.

Feature design https://github.com/openshift/enhancements/pull/1456

[1] https://github.com/openshift/api/pull/1913

Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

Jira Ticket:

https://issues.redhat.com/browse/CNV-42721

Release note:

Support deploying KubevirtIpamController via a feature gate
kubevirt-bot commented 1 month ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] commented 1 month ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

oshoval commented 1 month ago

Addressed comments, lets wait for CNAO to run the tests and so on Thanks

oshoval commented 1 month ago

Thanks @nunnatsa rebased, now it is ready please lets see all pass

coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 9658449603

Details

Totals Coverage Status
Change from base Build 9658355966: 0.02%
Covered Lines: 5223
Relevant Lines: 6083
💛 - Coveralls
coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 9658771855

Details

Totals Coverage Status
Change from base Build 9658355966: 0.007%
Covered Lines: 5222
Relevant Lines: 6083
💛 - Coveralls
kubevirt-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/hyperconverged-cluster-operator/blob/main/OWNERS)~~ [nunnatsa] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
oshoval commented 1 month ago

Thanks !

coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 9659567755

Details

Totals Coverage Status
Change from base Build 9658355966: 0.007%
Covered Lines: 5222
Relevant Lines: 6083
💛 - Coveralls
openshift-ci[bot] commented 1 month ago

@oshoval: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/hco-e2e-upgrade-prev-operator-sdk-aws 33604bdbbd6815019775ef0d18c7fcc5a3ca2b1c link true /test hco-e2e-upgrade-prev-operator-sdk-aws
ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-azure 33604bdbbd6815019775ef0d18c7fcc5a3ca2b1c link true /test hco-e2e-consecutive-operator-sdk-upgrades-azure
ci/prow/hco-e2e-kv-smoke-azure 33604bdbbd6815019775ef0d18c7fcc5a3ca2b1c link true /test hco-e2e-kv-smoke-azure

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
hco-bot commented 1 month ago

hco-e2e-kv-smoke-gcp lane succeeded. /override ci/prow/hco-e2e-kv-smoke-azure hco-e2e-consecutive-operator-sdk-upgrades-aws lane succeeded. /override ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-azure hco-e2e-upgrade-prev-operator-sdk-azure lane succeeded. /override ci/prow/hco-e2e-upgrade-prev-operator-sdk-aws

kubevirt-bot commented 1 month ago

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-azure, ci/prow/hco-e2e-kv-smoke-azure, ci/prow/hco-e2e-upgrade-prev-operator-sdk-aws

In response to [this](https://github.com/kubevirt/hyperconverged-cluster-operator/pull/3006#issuecomment-2189185535): >hco-e2e-kv-smoke-gcp lane succeeded. >/override ci/prow/hco-e2e-kv-smoke-azure >hco-e2e-consecutive-operator-sdk-upgrades-aws lane succeeded. >/override ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-azure >hco-e2e-upgrade-prev-operator-sdk-azure lane succeeded. >/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-aws > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
oshoval commented 1 month ago

/retest