[Release 1.11] Fix bug in community CSV

nunnatsa commented 4 weeks ago

The CSV namespace is "placeholder" by default, but must be "kubevirt-hyperconverged".

This PR fixes this issue.

What this PR does / why we need it:

Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

[ ] PR Message
[ ] Commit Messages
[ ] How to test
[ ] Unit Tests
[ ] Functional Tests
[ ] User Documentation
[ ] Developer Documentation
[ ] Upgrade Scenario
[ ] Uninstallation Scenario
[ ] Backward Compatibility
[ ] Troubleshooting Friendly

Jira Ticket:

None

Release note:

Fix community CSV installation at the wrong namespace

coveralls commented 4 weeks ago

Pull Request Test Coverage Report for Build 9691521738

Details

0 of 0 changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.02%) to 86.628%

Files with Coverage Reduction	New Missed Lines	%
controllers/operands/operandHandler.go	1	86.18%
<!--	Total:	1		-->

Totals
Change from base Build 9666413650:	-0.02%
Covered Lines:	5416
Relevant Lines:	6252

💛 - Coveralls

openshift-ci[bot] commented 4 weeks ago

@nunnatsa: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/hco-e2e-operator-sdk-aws	49a8ded80cf914bab139cb0bd74b3eaba0c33653	link	true	`/test hco-e2e-operator-sdk-aws`
ci/prow/hco-e2e-operator-sdk-gcp	49a8ded80cf914bab139cb0bd74b3eaba0c33653	link	true	`/test hco-e2e-operator-sdk-gcp`
ci/prow/hco-e2e-operator-sdk-sno-azure	49a8ded80cf914bab139cb0bd74b3eaba0c33653	link	false	`/test hco-e2e-operator-sdk-sno-azure`
ci/prow/hco-e2e-kv-smoke-azure	49a8ded80cf914bab139cb0bd74b3eaba0c33653	link	true	`/test hco-e2e-kv-smoke-azure`
ci/prow/hco-e2e-upgrade-operator-sdk-azure	49a8ded80cf914bab139cb0bd74b3eaba0c33653	link	true	`/test hco-e2e-upgrade-operator-sdk-azure`
ci/prow/hco-e2e-upgrade-prev-operator-sdk-azure	49a8ded80cf914bab139cb0bd74b3eaba0c33653	link	true	`/test hco-e2e-upgrade-prev-operator-sdk-azure`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

hco-bot commented 4 weeks ago

hco-e2e-upgrade-prev-operator-sdk-aws lane succeeded. /override ci/prow/hco-e2e-upgrade-prev-operator-sdk-azure hco-e2e-upgrade-operator-sdk-aws lane succeeded. /override ci/prow/hco-e2e-upgrade-operator-sdk-azure hco-e2e-operator-sdk-azure lane succeeded. /override ci/prow/hco-e2e-operator-sdk-gcp hco-e2e-operator-sdk-azure lane succeeded. /override ci/prow/hco-e2e-operator-sdk-aws hco-e2e-operator-sdk-sno-aws lane succeeded. /override ci/prow/hco-e2e-operator-sdk-sno-azure hco-e2e-upgrade-prev-operator-sdk-sno-aws lane succeeded. /override ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure

kubevirt-bot commented 4 weeks ago

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-operator-sdk-aws, ci/prow/hco-e2e-operator-sdk-gcp, ci/prow/hco-e2e-operator-sdk-sno-azure, ci/prow/hco-e2e-upgrade-operator-sdk-azure, ci/prow/hco-e2e-upgrade-prev-operator-sdk-azure, ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure

In response to [this](https://github.com/kubevirt/hyperconverged-cluster-operator/pull/3013#issuecomment-2194115005): >hco-e2e-upgrade-prev-operator-sdk-aws lane succeeded. >/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-azure >hco-e2e-upgrade-operator-sdk-aws lane succeeded. >/override ci/prow/hco-e2e-upgrade-operator-sdk-azure >hco-e2e-operator-sdk-azure lane succeeded. >/override ci/prow/hco-e2e-operator-sdk-gcp >hco-e2e-operator-sdk-azure lane succeeded. >/override ci/prow/hco-e2e-operator-sdk-aws >hco-e2e-operator-sdk-sno-aws lane succeeded. >/override ci/prow/hco-e2e-operator-sdk-sno-azure >hco-e2e-upgrade-prev-operator-sdk-sno-aws lane succeeded. >/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

nunnatsa commented 4 weeks ago

/override-bot

hco-bot commented 4 weeks ago

hco-e2e-kv-smoke-gcp lane succeeded. /override ci/prow/hco-e2e-kv-smoke-azure

kubevirt-bot commented 4 weeks ago

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-azure

In response to [this](https://github.com/kubevirt/hyperconverged-cluster-operator/pull/3013#issuecomment-2194177028): >hco-e2e-kv-smoke-gcp lane succeeded. >/override ci/prow/hco-e2e-kv-smoke-azure > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

tiraboschi commented 3 weeks ago

/approve

kubevirt-bot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tiraboschi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/hyperconverged-cluster-operator/blob/release-1.11/OWNERS)~~ [tiraboschi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

kubevirt / hyperconverged-cluster-operator