Closed orenc1 closed 2 months ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from orenc1. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Totals | |
---|---|
Change from base Build 9842265518: | 0.02% |
Covered Lines: | 5212 |
Relevant Lines: | 6068 |
@orenc1 I don't think this change will help. The problem is not in HCO, I think. As you can see, the CRD was not changed by your change, and the CRD is the input to the UI.
Also, it was never marked as as a required field in the CRD, so it's already optional.
@orenc1 I don't think this change will help. The problem is not in HCO, I think. As you can see, the CRD was not changed by your change, and the CRD is the input to the UI.
Also, it was never marked as as a required field in the CRD, so it's already optional.
but permittedHostDevices
and its subfields are also marked as optional, and they are not appearing by default in the UI on HyperConverged creation page. how it is possible?
permittedHostDevices
I can guess it's because these fields are array (slices), and this one is boolean.
Anyway, this is not an HCO bug.
permittedHostDevices
I can guess it's because these fields are array (slices), and this one is boolean.
Anyway, this is not an HCO bug.
I think it's because we're setting default values. I'm checking what happens when the default is not being set (PR is updated)
/hold
@orenc1: The following test failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
pull-hyperconverged-cluster-operator-e2e-k8s-1.29 | 1567756902199cba87729cbc3679aed899a4dfd5 | link | true | /test pull-hyperconverged-cluster-operator-e2e-k8s-1.29 |
@orenc1: The following tests failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
ci/prow/hco-e2e-upgrade-prev-operator-sdk-aws | 1567756902199cba87729cbc3679aed899a4dfd5 | link | true | /test hco-e2e-upgrade-prev-operator-sdk-aws |
ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-azure | 1567756902199cba87729cbc3679aed899a4dfd5 | link | true | /test hco-e2e-consecutive-operator-sdk-upgrades-azure |
ci/prow/hco-e2e-kv-smoke-azure | 1567756902199cba87729cbc3679aed899a4dfd5 | link | true | /test hco-e2e-kv-smoke-azure |
Full PR test history. Your PR dashboard.
See #2788
In order for the UI not to render a default value for
applicationAwareConfig
subfields for theHyperConverged
custom resource, those should be set as optional as well.What this PR does / why we need it:
Reviewer Checklist
Jira Ticket:
Release note: