kubevirt / hyperconverged-cluster-operator

Operator pattern for managing multi-operator products
Apache License 2.0
145 stars 148 forks source link

Ensure PodDisruptionBudgetAtLimit alert is silenced #3020

Closed machadovilaca closed 1 week ago

machadovilaca commented 2 weeks ago

What this PR does / why we need it:

The Pod Disruption Budget (PDB) prevents pod disruptions for migratable virtual machine images. If the PDB detects pod disruption, then openshift-monitoring sends a PodDisruptionBudgetAtLimit alert every 60 minutes, for every namespace, which includes virtual machine images that use the LiveMigrate eviction strategy. This is causing noise for all OpenShift Virtualization operator users.

Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

Jira Ticket:

https://issues.redhat.com/browse/CNV-43361
https://issues.redhat.com/browse/CNV-33834

Release note:

Ensure PodDisruptionBudgetAtLimit alert is silenced
coveralls commented 2 weeks ago

Pull Request Test Coverage Report for Build 9973443225

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/alertmanager/silences.go 42 65 64.62%
<!-- Total: 42 65 64.62% -->
Files with Coverage Reduction New Missed Lines %
controllers/operands/operandHandler.go 1 86.18%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 9972285232: -0.2%
Covered Lines: 5253
Relevant Lines: 6133

💛 - Coveralls
machadovilaca commented 2 weeks ago

/retest

tiraboschi commented 1 week ago

/retest

tiraboschi commented 1 week ago

/override-bot

hco-bot commented 1 week ago

hco-e2e-consecutive-operator-sdk-upgrades-aws lane succeeded. /override ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-azure hco-e2e-upgrade-operator-sdk-sno-azure lane succeeded. /override ci/prow/hco-e2e-upgrade-operator-sdk-sno-aws

kubevirt-bot commented 1 week ago

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-azure, ci/prow/hco-e2e-upgrade-operator-sdk-sno-aws

In response to [this](https://github.com/kubevirt/hyperconverged-cluster-operator/pull/3020#issuecomment-2228342648): >hco-e2e-consecutive-operator-sdk-upgrades-aws lane succeeded. >/override ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-azure >hco-e2e-upgrade-operator-sdk-sno-azure lane succeeded. >/override ci/prow/hco-e2e-upgrade-operator-sdk-sno-aws > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
tiraboschi commented 1 week ago

hco-e2e-upgrade-prev-operator-sdk-aws lane succeeded. /override ci/prow/hco-e2e-upgrade-prev-operator-sdk-azure

kubevirt-bot commented 1 week ago

@tiraboschi: Overrode contexts on behalf of tiraboschi: ci/prow/hco-e2e-upgrade-prev-operator-sdk-azure

In response to [this](https://github.com/kubevirt/hyperconverged-cluster-operator/pull/3020#issuecomment-2228403208): >hco-e2e-upgrade-prev-operator-sdk-aws lane succeeded. >/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-azure Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
machadovilaca commented 1 week ago

@nunnatsa can you please also take a look?

machadovilaca commented 1 week ago

@nunnatsa thank you, all updated

hco-bot commented 1 week ago

hco-e2e-upgrade-operator-sdk-azure lane succeeded. /override ci/prow/hco-e2e-upgrade-operator-sdk-aws hco-e2e-upgrade-prev-operator-sdk-azure lane succeeded. /override ci/prow/hco-e2e-upgrade-prev-operator-sdk-aws hco-e2e-upgrade-operator-sdk-sno-aws lane succeeded. /override ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure

kubevirt-bot commented 1 week ago

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-operator-sdk-aws, ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure, ci/prow/hco-e2e-upgrade-prev-operator-sdk-aws

In response to [this](https://github.com/kubevirt/hyperconverged-cluster-operator/pull/3020#issuecomment-2232630692): >hco-e2e-upgrade-operator-sdk-azure lane succeeded. >/override ci/prow/hco-e2e-upgrade-operator-sdk-aws >hco-e2e-upgrade-prev-operator-sdk-azure lane succeeded. >/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-aws >hco-e2e-upgrade-operator-sdk-sno-aws lane succeeded. >/override ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
nunnatsa commented 1 week ago

/retest

nunnatsa commented 1 week ago

/approve

kubevirt-bot commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/hyperconverged-cluster-operator/blob/main/OWNERS)~~ [nunnatsa] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
nunnatsa commented 1 week ago

/lgtm

machadovilaca commented 1 week ago

/retest

machadovilaca commented 1 week ago

/retest

openshift-ci[bot] commented 1 week ago

@machadovilaca: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/hco-e2e-upgrade-prev-operator-sdk-aws f376283aeffe485bb7a8d49e75966256b7ee41ab link true /test hco-e2e-upgrade-prev-operator-sdk-aws
ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-azure f376283aeffe485bb7a8d49e75966256b7ee41ab link true /test hco-e2e-consecutive-operator-sdk-upgrades-azure

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
nunnatsa commented 1 week ago

/override-bot

hco-bot commented 1 week ago

hco-e2e-upgrade-prev-operator-sdk-azure lane succeeded. /override ci/prow/hco-e2e-upgrade-prev-operator-sdk-aws

kubevirt-bot commented 1 week ago

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-operator-sdk-aws

In response to [this](https://github.com/kubevirt/hyperconverged-cluster-operator/pull/3020#issuecomment-2233986270): >hco-e2e-upgrade-prev-operator-sdk-azure lane succeeded. >/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-aws > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
nunnatsa commented 1 week ago

hco-e2e-consecutive-operator-sdk-upgrades-aws lane passed

/override ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-azure

kubevirt-bot commented 1 week ago

@nunnatsa: Overrode contexts on behalf of nunnatsa: ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-azure

In response to [this](https://github.com/kubevirt/hyperconverged-cluster-operator/pull/3020#issuecomment-2233992641): >hco-e2e-consecutive-operator-sdk-upgrades-aws lane passed > >/override ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-azure Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.