search

kubevirt / hyperconverged-cluster-operator

Operator pattern for managing multi-operator products
Apache License 2.0
154 stars 153 forks source link

dataImportCronTemplates: Remove CentOS 7 & stream 8 #3048

Closed lyarwood closed 2 months ago

lyarwood commented 2 months ago

What this PR does / why we need it:

Both releases are now EOL with their associated containerdisks also deprecated ahead of removal in the near future:

https://github.com/kubevirt/containerdisks/issues/154 https://github.com/kubevirt/containerdisks/issues/152

Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

Jira Ticket:

https://issues.redhat.com/browse/CNV-43911

Release note:

CentOS 7 & CentOS stream 8 are now EOL so the associated `DataImportCronTemplates` have been removed
coveralls commented 2 months ago

Pull Request Test Coverage Report for Build 10509285962

Details

Totals Coverage Status
Change from base Build 10509043708: 0.0%
Covered Lines: 5304
Relevant Lines: 6185
💛 - Coveralls
lyarwood commented 2 months ago

/retest-required

nunnatsa commented 2 months ago

Thanks for the PR @lyarwood

Please also fix https://github.com/kubevirt/hyperconverged-cluster-operator/blob/ee5ba66728bdf7275b3d4dd836206a9a3217565e/tests/func-tests/golden_image_test.go#L35

lyarwood commented 2 months ago

/hold

nunnatsa commented 2 months ago

@lyarwood Another change needed in the functional test - sorry for missing that.

Please also update the expectedImageStreams variable in https://github.com/kubevirt/hyperconverged-cluster-operator/blob/ee5ba66728bdf7275b3d4dd836206a9a3217565e/tests/func-tests/golden_image_test.go#L37-L43

lyarwood commented 2 months ago

@lyarwood Another change needed in the functional test - sorry for missing that.

Please also update the expectedImageStreams variable in https://github.com/kubevirt/hyperconverged-cluster-operator/blob/ee5ba66728bdf7275b3d4dd836206a9a3217565e/tests/func-tests/golden_image_test.go#L37-L43

Yup sorry didn't have time to fix this up yet thus the hold, will find time today.

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

lyarwood commented 2 months ago

/hold cancel

Should be fixed now, I had just mistakenly used the image stream name in UsageImages instead of the DataImportCron name.

hco-bot commented 2 months ago

hco-e2e-upgrade-prev-operator-sdk-aws lane succeeded. /override ci/prow/hco-e2e-upgrade-prev-operator-sdk-azure hco-e2e-operator-sdk-sno-aws lane succeeded. /override ci/prow/hco-e2e-operator-sdk-sno-azure

kubevirt-bot commented 2 months ago

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-operator-sdk-sno-azure, ci/prow/hco-e2e-upgrade-prev-operator-sdk-azure

In response to [this](https://github.com/kubevirt/hyperconverged-cluster-operator/pull/3048#issuecomment-2304937451): >hco-e2e-upgrade-prev-operator-sdk-aws lane succeeded. >/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-azure >hco-e2e-operator-sdk-sno-aws lane succeeded. >/override ci/prow/hco-e2e-operator-sdk-sno-azure > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
hco-bot commented 2 months ago

hco-e2e-operator-sdk-sno-aws lane succeeded. /override ci/prow/hco-e2e-operator-sdk-sno-azure hco-e2e-upgrade-operator-sdk-sno-aws lane succeeded. /override ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure hco-e2e-upgrade-prev-operator-sdk-sno-aws lane succeeded. /override ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure

kubevirt-bot commented 2 months ago

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-operator-sdk-sno-azure, ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure, ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure

In response to [this](https://github.com/kubevirt/hyperconverged-cluster-operator/pull/3048#issuecomment-2305031325): >hco-e2e-operator-sdk-sno-aws lane succeeded. >/override ci/prow/hco-e2e-operator-sdk-sno-azure >hco-e2e-upgrade-operator-sdk-sno-aws lane succeeded. >/override ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure >hco-e2e-upgrade-prev-operator-sdk-sno-aws lane succeeded. >/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
hco-bot commented 2 months ago

hco-e2e-consecutive-operator-sdk-upgrades-aws lane succeeded. /override ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-azure

kubevirt-bot commented 2 months ago

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-azure

In response to [this](https://github.com/kubevirt/hyperconverged-cluster-operator/pull/3048#issuecomment-2305146318): >hco-e2e-consecutive-operator-sdk-upgrades-aws lane succeeded. >/override ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-azure > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
kubevirt-bot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/hyperconverged-cluster-operator/blob/main/OWNERS)~~ [nunnatsa] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 2 months ago

@lyarwood: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure 8e909d44b6f7f5dddbbcafd8962a45038bb01c48 link false /test hco-e2e-upgrade-prev-operator-sdk-sno-azure
ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure 8e909d44b6f7f5dddbbcafd8962a45038bb01c48 link false /test hco-e2e-upgrade-operator-sdk-sno-azure
ci/prow/hco-e2e-operator-sdk-sno-azure 8e909d44b6f7f5dddbbcafd8962a45038bb01c48 link false /test hco-e2e-operator-sdk-sno-azure
ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-azure 8e909d44b6f7f5dddbbcafd8962a45038bb01c48 link true /test hco-e2e-consecutive-operator-sdk-upgrades-azure
ci/prow/hco-e2e-kv-smoke-azure 8e909d44b6f7f5dddbbcafd8962a45038bb01c48 link true /test hco-e2e-kv-smoke-azure

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
hco-bot commented 2 months ago

hco-e2e-kv-smoke-gcp lane succeeded. /override ci/prow/hco-e2e-kv-smoke-azure

kubevirt-bot commented 2 months ago

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-azure

In response to [this](https://github.com/kubevirt/hyperconverged-cluster-operator/pull/3048#issuecomment-2305281024): >hco-e2e-kv-smoke-gcp lane succeeded. >/override ci/prow/hco-e2e-kv-smoke-azure > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
0xFelix commented 2 months ago

/cherry-pick release-1.12 /cherry-pick release-1.11 /cherry-pick release-1.10 /cherry-pick release-1.9

0xFelix commented 2 months ago

/cherry-pick release-1.8

kubevirt-bot commented 2 months ago

@0xFelix: #3048 failed to apply on top of branch "release-1.12":

Applying: dataImportCronTemplates: Remove CentOS 7 & stream 8
Using index info to reconstruct a base tree...
M   assets/dataImportCronTemplates/dataImportCronTemplates.yaml
M   tests/func-tests/golden_image_test.go
Falling back to patching base and 3-way merge...
Auto-merging tests/func-tests/golden_image_test.go
CONFLICT (content): Merge conflict in tests/func-tests/golden_image_test.go
Auto-merging assets/dataImportCronTemplates/dataImportCronTemplates.yaml
CONFLICT (content): Merge conflict in assets/dataImportCronTemplates/dataImportCronTemplates.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 dataImportCronTemplates: Remove CentOS 7 & stream 8
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/kubevirt/hyperconverged-cluster-operator/pull/3048#issuecomment-2309696871): >/cherry-pick release-1.12 >/cherry-pick release-1.11 >/cherry-pick release-1.10 >/cherry-pick release-1.9 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
kubevirt-bot commented 2 months ago

@0xFelix: #3048 failed to apply on top of branch "release-1.8":

Applying: dataImportCronTemplates: Remove CentOS 7 & stream 8
Using index info to reconstruct a base tree...
A   tests/func-tests/golden_image_test.go
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): tests/func-tests/golden_image_test.go deleted in HEAD and modified in dataImportCronTemplates: Remove CentOS 7 & stream 8. Version dataImportCronTemplates: Remove CentOS 7 & stream 8 of tests/func-tests/golden_image_test.go left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 dataImportCronTemplates: Remove CentOS 7 & stream 8
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/kubevirt/hyperconverged-cluster-operator/pull/3048#issuecomment-2309697045): >/cherry-pick release-1.8 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.