Improve the monitoring functional test

nunnatsa commented 3 weeks ago

The test now reads the kubevirt_hco_out_of_band_modifications_total metric before modifying the KubeVirt CR. When reading from prometheus, it can take some time for it to update from the HCO endpoints. That leads to flaky behavior, because the initial value may be wrong and not up-to-date.

This PR reads the initial value directly from the HCO pod, by adding a temporary route for the HCO prometheus endpoint, so it is always up-to-date.

The monitoring test can only run on OpenShift clusters. That allow us to use routers.

Jira Ticket:

None

Release note:

None

coveralls commented 3 weeks ago

Pull Request Test Coverage Report for Build 10555262519

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 85.756%

Totals
Change from base Build 10517150659:	0.0%
Covered Lines:	5304
Relevant Lines:	6185

💛 - Coveralls

hco-bot commented 3 weeks ago

hco-e2e-operator-sdk-gcp lane succeeded. /override ci/prow/hco-e2e-operator-sdk-azure hco-e2e-operator-sdk-gcp lane succeeded. /override ci/prow/hco-e2e-operator-sdk-aws

kubevirt-bot commented 3 weeks ago

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-operator-sdk-aws, ci/prow/hco-e2e-operator-sdk-azure

In response to [this](https://github.com/kubevirt/hyperconverged-cluster-operator/pull/3063#issuecomment-2304817403): >hco-e2e-operator-sdk-gcp lane succeeded. >/override ci/prow/hco-e2e-operator-sdk-azure >hco-e2e-operator-sdk-gcp lane succeeded. >/override ci/prow/hco-e2e-operator-sdk-aws > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

hco-bot commented 3 weeks ago

hco-e2e-upgrade-operator-sdk-sno-aws lane succeeded. /override ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure

kubevirt-bot commented 3 weeks ago

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure

In response to [this](https://github.com/kubevirt/hyperconverged-cluster-operator/pull/3063#issuecomment-2304856926): >hco-e2e-upgrade-operator-sdk-sno-aws lane succeeded. >/override ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

hco-bot commented 3 weeks ago

hco-e2e-upgrade-prev-operator-sdk-aws lane succeeded. /override ci/prow/hco-e2e-upgrade-prev-operator-sdk-azure

kubevirt-bot commented 3 weeks ago

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-operator-sdk-azure

In response to [this](https://github.com/kubevirt/hyperconverged-cluster-operator/pull/3063#issuecomment-2304874384): >hco-e2e-upgrade-prev-operator-sdk-aws lane succeeded. >/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-azure > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

hco-bot commented 3 weeks ago

hco-e2e-operator-sdk-sno-azure lane succeeded. /override ci/prow/hco-e2e-operator-sdk-sno-aws hco-e2e-upgrade-operator-sdk-sno-aws lane succeeded. /override ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure

kubevirt-bot commented 3 weeks ago

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-operator-sdk-sno-aws, ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure

In response to [this](https://github.com/kubevirt/hyperconverged-cluster-operator/pull/3063#issuecomment-2304937348): >hco-e2e-operator-sdk-sno-azure lane succeeded. >/override ci/prow/hco-e2e-operator-sdk-sno-aws >hco-e2e-upgrade-operator-sdk-sno-aws lane succeeded. >/override ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

hco-bot commented 3 weeks ago

hco-e2e-consecutive-operator-sdk-upgrades-aws lane succeeded. /override ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-azure

kubevirt-bot commented 3 weeks ago

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-azure

In response to [this](https://github.com/kubevirt/hyperconverged-cluster-operator/pull/3063#issuecomment-2305031186): >hco-e2e-consecutive-operator-sdk-upgrades-aws lane succeeded. >/override ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-azure > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

hco-bot commented 3 weeks ago

hco-e2e-kv-smoke-gcp lane succeeded. /override ci/prow/hco-e2e-kv-smoke-azure

kubevirt-bot commented 3 weeks ago

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-azure

In response to [this](https://github.com/kubevirt/hyperconverged-cluster-operator/pull/3063#issuecomment-2305280982): >hco-e2e-kv-smoke-gcp lane succeeded. >/override ci/prow/hco-e2e-kv-smoke-azure > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

sonarcloud[bot] commented 3 weeks ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

tiraboschi commented 3 weeks ago

/approve

kubevirt-bot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tiraboschi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/hyperconverged-cluster-operator/blob/main/OWNERS)~~ [tiraboschi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

hco-bot commented 3 weeks ago

hco-e2e-upgrade-operator-sdk-sno-aws lane succeeded. /override ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure

kubevirt-bot commented 3 weeks ago

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure

In response to [this](https://github.com/kubevirt/hyperconverged-cluster-operator/pull/3063#issuecomment-2309678661): >hco-e2e-upgrade-operator-sdk-sno-aws lane succeeded. >/override ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

hco-bot commented 3 weeks ago

hco-e2e-upgrade-prev-operator-sdk-sno-aws lane succeeded. /override ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure

kubevirt-bot commented 3 weeks ago

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure

In response to [this](https://github.com/kubevirt/hyperconverged-cluster-operator/pull/3063#issuecomment-2309693350): >hco-e2e-upgrade-prev-operator-sdk-sno-aws lane succeeded. >/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

hco-bot commented 3 weeks ago

hco-e2e-upgrade-prev-operator-sdk-sno-aws lane succeeded. /override ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure

kubevirt-bot commented 3 weeks ago

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure

In response to [this](https://github.com/kubevirt/hyperconverged-cluster-operator/pull/3063#issuecomment-2309730768): >hco-e2e-upgrade-prev-operator-sdk-sno-aws lane succeeded. >/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

hco-bot commented 3 weeks ago

hco-e2e-upgrade-operator-sdk-azure lane succeeded. /override ci/prow/hco-e2e-upgrade-operator-sdk-aws hco-e2e-consecutive-operator-sdk-upgrades-aws lane succeeded. /override ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-azure

kubevirt-bot commented 3 weeks ago

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-azure, ci/prow/hco-e2e-upgrade-operator-sdk-aws

In response to [this](https://github.com/kubevirt/hyperconverged-cluster-operator/pull/3063#issuecomment-2309780531): >hco-e2e-upgrade-operator-sdk-azure lane succeeded. >/override ci/prow/hco-e2e-upgrade-operator-sdk-aws >hco-e2e-consecutive-operator-sdk-upgrades-aws lane succeeded. >/override ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-azure > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

openshift-ci[bot] commented 3 weeks ago

@nunnatsa: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/hco-e2e-upgrade-operator-sdk-aws	0ffc8d4d14ee717cf8ffc3ec57035062fce38d36	link	true	`/test hco-e2e-upgrade-operator-sdk-aws`
ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure	0ffc8d4d14ee717cf8ffc3ec57035062fce38d36	link	false	`/test hco-e2e-upgrade-prev-operator-sdk-sno-azure`
ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-azure	0ffc8d4d14ee717cf8ffc3ec57035062fce38d36	link	true	`/test hco-e2e-consecutive-operator-sdk-upgrades-azure`
ci/prow/hco-e2e-kv-smoke-azure	0ffc8d4d14ee717cf8ffc3ec57035062fce38d36	link	true	`/test hco-e2e-kv-smoke-azure`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

nunnatsa commented 3 weeks ago

/override-bot

hco-bot commented 3 weeks ago

hco-e2e-kv-smoke-gcp lane succeeded. /override ci/prow/hco-e2e-kv-smoke-azure

kubevirt-bot commented 3 weeks ago

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-azure

In response to [this](https://github.com/kubevirt/hyperconverged-cluster-operator/pull/3063#issuecomment-2309963593): >hco-e2e-kv-smoke-gcp lane succeeded. >/override ci/prow/hco-e2e-kv-smoke-azure > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

kubevirt / hyperconverged-cluster-operator