kubevirt / hyperconverged-cluster-operator

Operator pattern for managing multi-operator products
Apache License 2.0
154 stars 152 forks source link

deploy_kustomize.sh uses non-portable paths #726

Closed colonwq closed 4 years ago

colonwq commented 4 years ago

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:

/kind bug /kind enhancement

What happened: deploy_kustomize.sh has two calls to sed which are relative to the base directory of the git repo.

These calls fail if the script is not ran from the base directory of the git repo.

What you expected to happen: The sed calls should be able to run from any directory including the kustomize directory

How to reproduce it (as minimally and precisely as possible): cd deploy/kustomize ./deploy_kustomize.sh

Anything else we need to know?:

Environment:

colonwq commented 4 years ago

See PR #727

orenc1 commented 4 years ago

Thanks @colonwq , your PR has been merged. Closing this issue.