The plugins are missing tests

kubevirt / kubernetes-device-plugins

Incubating: A number of Kubernetes device-plugins developed and useful for KubeVirt

MIT License

43 stars 37 forks source link

The plugins are missing tests #14

Closed mpolednik closed 5 years ago

mpolednik commented 6 years ago

Currently, there are no tests for the plugin themselves and only simple test for manager. This should be our top priority, as having untested code handle devices in the system is extremely dangerous.

General ideas:

let's consider gomega/ginkgo for BDD (depends on setup/teardown complexity compared to gotest)
mock Kubelet's device plugin gRPC API to have properly tested manager code
have unit + functional tests of the plugins (subject to hw requirements)

mpolednik commented 6 years ago

CC @phoracek as networking will be I suppose the most difficult to keep tested.

fabiand commented 6 years ago

As logn as the plugins are single node you can consider:

https://kinvolk.io/blog/2017/10/running-kubernetes-on-travis-ci-with-minikube/

phoracek commented 6 years ago

I feel like it would be easier to create functional tests than mocking for most of it.

mpolednik commented 6 years ago

The minikube-on-travis looks beautiful - looking into having that. @phoracek they would, but we need need something a) simple enough for make test, b) complex functional suite c) CI compatible tests.

kubevirt-bot commented 5 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

kubevirt-bot commented 5 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

kubevirt-bot commented 5 years ago

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

/close

kubevirt-bot commented 5 years ago

@kubevirt-bot: Closing this issue.

In response to [this](https://github.com/kubevirt/kubernetes-device-plugins/issues/14#issuecomment-447550650): >Rotten issues close after 30d of inactivity. >Reopen the issue with `/reopen`. >Mark the issue as fresh with `/remove-lifecycle rotten`. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.