kubevirt / kubesecondarydns

DNS for KubeVirt VirtualMachines secondary interfaces
Apache License 2.0
7 stars 8 forks source link

manifest: Add default container #14

Closed oshoval closed 1 year ago

oshoval commented 1 year ago

This way we can run commands like kubectl logs without specifying the container with -c status-monitor as we usually need the status-monitor and not the secondary-dns container.

Had to bump to use k8s-1.25 so we can use kubectl.kubernetes.io/default-container and not the deprecated one kubectl.kubernetes.io/default-logs-container.

Note that it works only on 1.25 +

oshoval commented 1 year ago

Bumped to 1.25 and used the new annotation

AlonaKaplan commented 1 year ago

Pleas split the bump to a separate commit, so we will have a nice history.

oshoval commented 1 year ago

Pleas split the bump to a separate commit, so we will have a nice history.

Once upon a time...

oshoval commented 1 year ago

Split to commits