search

kubevirt / kubesecondarydns

DNS for KubeVirt VirtualMachines secondary interfaces
Apache License 2.0
7 stars 8 forks source link

Unit tests to interface_filter #26

Closed AlonaKaplan closed 1 year ago

AlonaKaplan commented 1 year ago

Signed-off-by: Alona Paz alkaplan@redhat.com

oshoval commented 1 year ago

we have each git actions lane twice pull_request and push .... need to fix maybe the actions

name: checks
on: [push, pull_request]
oshoval commented 1 year ago

Please change PR desc:

'status-manager: Add interface filter unit tests"

oshoval commented 1 year ago

https://stackoverflow.com/questions/70767090/github-actions-on-push-and-on-pull-request-difference#:~:text=In%20general%2C%20push%20will%20trigger,from%20a%20fork%20for%20example.

There were double maybe because you used some other way to create a PR ? not sure because i see "alona-fork"

anyhow it doesnt happen on other PR i think, just ones maybe that you create, and we do need both actions (unless i am missing something) lets see how we fix it when time comes once we move repo we wont have this issue i believe