kubevirt / kubesecondarydns

DNS for KubeVirt VirtualMachines secondary interfaces
Apache License 2.0
7 stars 8 forks source link

makefile: Add basic cluster functions #3

Closed oshoval closed 1 year ago

oshoval commented 1 year ago

Add cluster make targets Align to the current docker file allows to deploy the deployment via cluster-sync

The latest kubevirtci which supports DNS is included.

The test and functest targets are stubs that will be addressed on follow PRs.

oshoval commented 1 year ago

Updated the kubevirtci tag because we had to delete the previous one due to other reasons

oshoval commented 1 year ago

Partial review

The PR was meant only to give partial targets for the stuff which aren't cluster related, rest are not tested. (see please PR desc as well) It was created even before you published the PR with the dockerfile anyhow I can either address in this PR or follow PRs the comments (of course that the conflicting parts i will address first)

oshoval commented 1 year ago

rebased

oshoval commented 1 year ago

Note that because of a tag mismatch kubevirtci will be cloned on each make operation until a new tag is created or until the tag is deleted ref https://github.com/kubevirt/kubevirt/pull/8688#issuecomment-1304829278

EDIT - i had to add a WA around it, because else it cleans the files that are needed for the deploy after the cluster is up.

oshoval commented 1 year ago

Addressed comments there is a WA that will need to be removed once there is a new kubevirtci tag (see comment above)

oshoval commented 1 year ago

Still TODO (maybe in this PR): include 2 nodes use env vars for DEPLOY_CNAO and DEPLOY_KUBEVIRT (nice to have)

oshoval commented 1 year ago

addressed the TODO in the comment above

oshoval commented 1 year ago

Removed the WA as the tag of kubevirtci which caused it, was deleted.