search

kubevirt / kubesecondarydns

DNS for KubeVirt VirtualMachines secondary interfaces
Apache License 2.0
7 stars 8 forks source link

images: Align registry and repo to be consistent with github actions #30

Closed oshoval closed 1 year ago

oshoval commented 1 year ago

Since we push to ghcr.io/alonakaplan with github actions, align all instances in the code to use those registry / repository.

Once we move under kubevirt we will align accordingly.

Signed-off-by: Or Shoval oshoval@redhat.com

AlonaKaplan commented 1 year ago

Since we push to ghcr.io/alonakaplan, align all instances in the code to use those or at least the repository name of the local ones. Registry can't be hardcoded because the port is determined each cluster-up.

Once we move under kubevirt we will align accordingly.

Signed-off-by: Or Shoval oshoval@redhat.com

The PR message is not clear. Please explain you're aligning to the container registry used by the github actions when pushing a PR. The reason why the local registry is not used can be omitted or rephrased.

oshoval commented 1 year ago

Done + rebased (no code changes, just commit message and PR desc were changed)