kubevirt / kubesecondarydns

DNS for KubeVirt VirtualMachines secondary interfaces
Apache License 2.0
7 stars 8 forks source link

git actions: Add PR template #35

Closed oshoval closed 1 year ago

oshoval commented 1 year ago

Signed-off-by: Or Shoval oshoval@redhat.com

None
dteplits commented 1 year ago

/approve

dteplits commented 1 year ago

/lgtm

oshoval commented 1 year ago

Addressed comments

AlonaKaplan commented 1 year ago

/approve

AlonaKaplan commented 1 year ago

@oshoval Side note, please make sure the release note are actually collected and added to the release.

oshoval commented 1 year ago

@oshoval Side note, please make sure the release note are actually collected and added to the release.

If there is no automation for it, i can remove it for now, because i can't create automation at the near future unless we have examples to be based on

AlonaKaplan commented 1 year ago

@oshoval Side note, please make sure the release note are actually collected and added to the release.

If there is no automation for it, i can remove it for now, because i can't create automation at the near future unless we have examples to be based on

Let's start from checking if it is magically working. If not, let's remove it from the template and from prow.

AlonaKaplan commented 1 year ago

/approve cancel let's first verify the release notes are working.

oshoval commented 1 year ago

Rebase

oshoval commented 1 year ago

It seems we need to add something like this (thanks Petr) https://github.com/nmstate/kubernetes-nmstate/blob/main/hack/render-release-notes.sh#L14

I prefer to not dive into it at the moment, first to close other stuff Can we merge the PR as is, and later add the functionality please ? The PR doesn't introduce a regression as is I will open a Jira ticket for it

AlonaKaplan commented 1 year ago

/lgtm /approve

kubevirt-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlonaKaplan, dteplits

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/kubesecondarydns/blob/main/OWNERS)~~ [AlonaKaplan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment