Closed oshoval closed 1 year ago
/approve
/lgtm
Addressed comments
/approve
@oshoval Side note, please make sure the release note are actually collected and added to the release.
@oshoval Side note, please make sure the release note are actually collected and added to the release.
If there is no automation for it, i can remove it for now, because i can't create automation at the near future unless we have examples to be based on
@oshoval Side note, please make sure the release note are actually collected and added to the release.
If there is no automation for it, i can remove it for now, because i can't create automation at the near future unless we have examples to be based on
Let's start from checking if it is magically working. If not, let's remove it from the template and from prow.
/approve cancel let's first verify the release notes are working.
Rebase
It seems we need to add something like this (thanks Petr) https://github.com/nmstate/kubernetes-nmstate/blob/main/hack/render-release-notes.sh#L14
I prefer to not dive into it at the moment, first to close other stuff Can we merge the PR as is, and later add the functionality please ? The PR doesn't introduce a regression as is I will open a Jira ticket for it
/lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: AlonaKaplan, dteplits
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Signed-off-by: Or Shoval oshoval@redhat.com