kubevirt / kubesecondarydns

DNS for KubeVirt VirtualMachines secondary interfaces
Apache License 2.0
7 stars 8 forks source link

manifest: Change default values of env vars #36

Closed oshoval closed 1 year ago

oshoval commented 1 year ago

Use empty strings as default values for the env vars. The Zone manager will set the defaults accordingly. This allows to deploy the manifest as is.

Since CNAO CR also doesn't have values, it will align the e2e test to work when running from CNAO (using default values).

None
dteplits commented 1 year ago

Use empty strings as default values for the env vars. The Zone manager will set the defaults accordingly. This allows the deploy the manifest as is.

None

I guess you meant "This allows to deploy the manifest as is."

oshoval commented 1 year ago

Right thanks, fixed and rebased

dteplits commented 1 year ago

/lgtm

oshoval commented 1 year ago

Rebase adjust the test accordingly

oshoval commented 1 year ago

https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_kubesecondarydns/36/pull-kubesecondarydns-e2e-k8s/1600149829063806976 failed here, lets see if always fails

/retest

oshoval commented 1 year ago

Weird that when going back and forth from draft the git actions aren't triggered

oshoval commented 1 year ago

Closed reopen fixed the git actions

AlonaKaplan commented 1 year ago

/approve

kubevirt-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlonaKaplan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/kubesecondarydns/blob/main/OWNERS)~~ [AlonaKaplan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
AlonaKaplan commented 1 year ago

/lgtm

oshoval commented 1 year ago

Thanks When you can please create a tag, so we can consume it on CNAO