Closed oshoval closed 1 year ago
Use empty strings as default values for the env vars. The Zone manager will set the defaults accordingly. This allows the deploy the manifest as is.
None
I guess you meant "This allows to deploy the manifest as is."
Right thanks, fixed and rebased
/lgtm
Rebase adjust the test accordingly
https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_kubesecondarydns/36/pull-kubesecondarydns-e2e-k8s/1600149829063806976 failed here, lets see if always fails
/retest
Weird that when going back and forth from draft the git actions aren't triggered
Closed reopen fixed the git actions
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: AlonaKaplan
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/lgtm
Thanks When you can please create a tag, so we can consume it on CNAO
Use empty strings as default values for the env vars. The Zone manager will set the defaults accordingly. This allows to deploy the manifest as is.
Since CNAO CR also doesn't have values, it will align the e2e test to work when running from CNAO (using default values).