search

kubevirt / kubesecondarydns

DNS for KubeVirt VirtualMachines secondary interfaces
Apache License 2.0
7 stars 8 forks source link

readme: Update readme file #37

Closed oshoval closed 1 year ago

oshoval commented 1 year ago

Includes:

Beside that: Ignore whitespace check on markdown files (double space at the end means new line).

None
dteplits commented 1 year ago

/lgtm

oshoval commented 1 year ago

Rebase

oshoval commented 1 year ago

Addressed comments

need to fix whitespace check to ignore it

oshoval commented 1 year ago

Fixed whitespace to ignore markdown files

oshoval commented 1 year ago

Addressed comments (beside https://github.com/kubevirt/kubesecondarydns/pull/37/files#r1045608648 yet)

oshoval commented 1 year ago

Updated manifest, also updated the image to be the same as the one we have on the test

EDIT fixing the commits

oshoval commented 1 year ago

Rebase Address this https://github.com/kubevirt/kubesecondarydns/pull/37#discussion_r1048529963

AlonaKaplan commented 1 year ago

/lgtm /approve Thanks!

kubevirt-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlonaKaplan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/kubesecondarydns/blob/main/OWNERS)~~ [AlonaKaplan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment