search

kubevirt / kubesecondarydns

DNS for KubeVirt VirtualMachines secondary interfaces
Apache License 2.0
7 stars 8 forks source link

cnao: Use cached version #42

Closed oshoval closed 1 year ago

oshoval commented 1 year ago

Use the cached CNAO version, without CR. The CR is deployed afterwards according the local CR that which we have in the KubeSecondaryDNS repository itself (deploys multus only).

It saves time because the images are already cached, and also eliminates the need to update CNAO versions, as bumping kubevirtci will take care about it.

In case the provider is external, CNAO CR won't be deployed. The cluster owner should have multus installed.

None
kubevirt-bot commented 1 year ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

oshoval commented 1 year ago

Rebased and updated logic.

AlonaKaplan commented 1 year ago

/lgtm /approve

kubevirt-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlonaKaplan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/kubesecondarydns/blob/main/OWNERS)~~ [AlonaKaplan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment