search

kubevirt / kubesecondarydns

DNS for KubeVirt VirtualMachines secondary interfaces
Apache License 2.0
7 stars 8 forks source link

[e2e] adding a period to the tested fqdn and improve error readability #44

Closed AlonaKaplan closed 1 year ago

AlonaKaplan commented 1 year ago

What this PR does / why we need it: The PR contains two commits. The first one is adding a period to the tested fqdn. According to the nslokkup man page - 

If the lookup request contains at least one period but doesn't end with a trailing period, append the domain names in the domain search list to the request until an answer is received.
To avoid this, a period is added to our fqdn.

The second one returns readable nslookup error.

Special notes for your reviewer:

Release note:

NONE
kubevirt-bot commented 1 year ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

AlonaKaplan commented 1 year ago

/test pull-kubesecondarydns-e2e-k8s

AlonaKaplan commented 1 year ago

/test pull-kubesecondarydns-e2e-k8s

AlonaKaplan commented 1 year ago

/test pull-kubesecondarydns-e2e-k8s

AlonaKaplan commented 1 year ago

/test pull-kubesecondarydns-e2e-k8s

oshoval commented 1 year ago

You might want to add please what happened on CI when there was no dot and no DOMAIN

AlonaKaplan commented 1 year ago

You might want to add please what happened on CI when there was no dot and no DOMAIN

** server can't find nic1.vmi-sec-v7tgz.secondary-test-frwp6.vm.kubevirt-prow-jobs.svc.cluster.local: SERVFAIL kubevirt-prow-jobs.svc.cluster.local domain was appended.

AlonaKaplan commented 1 year ago

/approve

kubevirt-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlonaKaplan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/kubesecondarydns/blob/main/OWNERS)~~ [AlonaKaplan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment