Adding missing nameserver name to custom A record

dteplits commented 1 year ago

In case custom variables are populated, for example:

DOMAIN=secondary.io
NAME_SERVER_IP=1.2.3.4

Then the zone file should contain the below two records (KubeSecondaryDNS nameserver details as defined in external domain server):

IN NS ns.vm.secondary.io.
ns IN A 1.2.3.4

This PR adds ns prefix inside the A record as shown above. ns is the default KubeSecondaryDNS nameserver name

The two records eventually will be converted by the DNS engine into this:

vm.secondary.io. IN NS ns.vm.secondary.io.
ns.vm.secondary.io. IN A 1.2.3.4

NS record has no prefix, therefore @ that comes in the line before (SOA record) should catch here. And be replaced by $ORIGIN value
A record has ns prefix but no . at the end therefore should be completed with $ORIGIN

Signed-off-by: Diana Teplits dteplits@redhat.com

NONE

dteplits commented 1 year ago

Thanks This PR adds ns prefix inside the IN record as shown above. you mean IN A right ?

I meant A record, fixed it, thanks for noticing

AlonaKaplan commented 1 year ago

/lgtm /approve

kubevirt-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlonaKaplan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/kubesecondarydns/blob/main/OWNERS)~~ [AlonaKaplan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

kubevirt / kubesecondarydns

Adding missing nameserver name to custom A record #49