search

kubevirt / kubesecondarydns

DNS for KubeVirt VirtualMachines secondary interfaces
Apache License 2.0
7 stars 8 forks source link

Zone manager package refactoring #51

Closed dteplits closed 1 year ago

dteplits commented 1 year ago

Zone manager package refactoring:

  1. Converting API functions to Public
  2. Moving ZoneFile and ZoneFileCache under internal/ package to prevent unnecessary usage of internal Public methods
  3. Adjusting unit tests to public/private access

Release note:

NONE
AlonaKaplan commented 1 year ago

/approve

kubevirt-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlonaKaplan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/kubesecondarydns/blob/main/OWNERS)~~ [AlonaKaplan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
AlonaKaplan commented 1 year ago

/lgtm