search

kubevirt / kubesecondarydns

DNS for KubeVirt VirtualMachines secondary interfaces
Apache License 2.0
7 stars 8 forks source link

manifest, psa: Use qemu UID #53

Closed oshoval closed 1 year ago

oshoval commented 1 year ago

What this PR does / why we need it: This way we can deloy it on CRC as well (tried with HCO on top of CRC)

Special notes for your reviewer:

Release note:

None
AlonaKaplan commented 1 year ago

/lgtm /approve

kubevirt-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlonaKaplan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/kubesecondarydns/blob/main/OWNERS)~~ [AlonaKaplan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
oshoval commented 1 year ago

I checked it wrong, it doesn't fix the problem

oshoval commented 1 year ago

@AlonaKaplan Should we revert this one back to 1000 so it will be like CNAO right ? (nicer even if not mandatory, unless 107 is better)