Closed AlonaKaplan closed 1 year ago
@AlonaKaplan: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.
Closing temporary till the project-infra is merged.
This template just ask the user to add the release notes nothing beside
Project infra already has the plugin Just the github actions was / is missing
This template just ask the user to add the release notes nothing beside
Project infra already has the plugin Just the github actions was / is missing
As the PR description says, the release github action already generate a releasen-note with out the need to manually add the text to each PR. It is more than enough.
I couldn't find a github action that collects the release-note from each PR and adds all those notes to the change-log. cnao for example are using k8s.io/release/cmd/release-notes binary to gather the notes from the PRs and generate the change log. We can use it as well and append it to our change log, but I find it redundant. The changelog generated by the github action is good enough.
This template just ask the user to add the release notes nothing beside Project infra already has the plugin Just the github actions was / is missing
As the PR description says, the release github action already generate a releasen-note with out the need to manually add the text to each PR. It is more than enough.
I couldn't find a github action that collects the release-note from each PR and adds all those notes to the change-log. cnao for example are using k8s.io/release/cmd/release-notes binary to gather the notes from the PRs and generate the change log. We can use it as well and append it to our change log, but I find it redundant. The changelog generated by the github action is good enough.
It collects the PR desc, original plan was indeed to add as CNAO does It might be less informative on special cases, but we can live without it for now.
This template just ask the user to add the release notes nothing beside Project infra already has the plugin Just the github actions was / is missing
As the PR description says, the release github action already generate a releasen-note with out the need to manually add the text to each PR. It is more than enough. I couldn't find a github action that collects the release-note from each PR and adds all those notes to the change-log. cnao for example are using k8s.io/release/cmd/release-notes binary to gather the notes from the PRs and generate the change log. We can use it as well and append it to our change log, but I find it redundant. The changelog generated by the github action is good enough.
It collects the PR desc, original plan was indeed to add as CNAO does It might be less informative on special cases, but we can live without it for now.
I discussed it will @qinqon and even in cnao they plan to stop using this binary. The changelog generated by the current github action is more than enough to this repo.
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: AlonaKaplan
The full list of commands accepted by this bot can be found here.
The pull request process is described here
What this PR does / why we need it: The repository has a github action that generates the changelog of the release with the PR title. It should be enough.
Special notes for your reviewer: The PR depends on https://github.com/kubevirt/project-infra/pull/2548