Closed RishabhKodes closed 1 year ago
Hi @RishabhKodes. Thanks for your PR.
I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
@xpivarc mentioned about this issue here, https://github.com/kubevirt/kubevirt/pull/9262#issuecomment-1443710928
/lgtm @AlonaKaplan
@RishabhKodes Thanks for the PR! The github action should be updated as well - https://github.com/kubevirt/kubesecondarydns/blob/main/.github/workflows/image-push.yaml#L56
@RishabhKodes Thanks for the PR! The github action should be updated as well - https://github.com/kubevirt/kubesecondarydns/blob/main/.github/workflows/image-push.yaml#L56
@AlonaKaplan not quite sure, what should be updated here?
@RishabhKodes Thanks for the PR! The github action should be updated as well - https://github.com/kubevirt/kubesecondarydns/blob/main/.github/workflows/image-push.yaml#L56
@AlonaKaplan not quite sure, what should be updated here?
Sorry, ignore my comment. I confused ghcr.io
with k8s.gcr.io
.
/approve /hold @oshoval please review the PR, feel free to remove the hold.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: AlonaKaplan
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Thank you for the contribution
/lgtm /hold cancel
It is weird that it didnt run the git actions jobs
@AlonaKaplan can you please issue a tag ? (manual bump is needed as well on CNAO afterwards)
We better bump CNAO to be aware of it, so in case the old domain doesn't work, it wont be broken on CNAO / HCO Thanks
What this PR does / why we need it: This PR is part of the Umbrella issue, https://github.com/kubernetes/k8s.io/issues/4780
Special notes for your reviewer: With the change to defaulting to registry.k8s.io as the image registry and the planned freeze in April, downstream projects will likely be impacted, so the image registry needs to be updated from k8s.gcr.io to registry.k8s.io.